Permalink
Browse files

Undo unwarranted change to coding conventions. I am not a fan of the …

…aesthetics of private/public at the root but more importantly, we should not be changing coding conventions with almost a decades worth of history at a whim. The conventions are there to have a consistent coding style, that is their primary purpose. When there is so much existing code with the existing style, any change will have to lift an enormous burden of proof as to why its overwhelmingly superior. That is not the case here, so this is being reverted.
  • Loading branch information...
dhh committed Mar 13, 2012
1 parent fc3e9b3 commit 46313151bd2ff419251543eda1b1122d4cc7c5ed
Showing with 1 addition and 0 deletions.
  1. +1 −0 railties/guides/source/contributing_to_ruby_on_rails.textile
@@ -310,6 +310,7 @@ Rails follows a simple set of coding style conventions.
* Two spaces, no tabs.
* No trailing whitespace. Blank lines should not have any space.
* Outdent private/protected from method definitions. Same indentation as the class/module.
+* Indent after private/protected.
* Prefer +&&+/+||+ over +and+/+or+.
* Prefer class << self block over self.method for class methods.
* +MyClass.my_method(my_arg)+ not +my_method( my_arg )+ or +my_method my_arg+.

2 comments on commit 4631315

@dmathieu

This comment has been minimized.

Show comment
Hide comment
@dmathieu

dmathieu Mar 13, 2012

Contributor

There are also good commit messages 😉

Contributor

dmathieu replied Mar 13, 2012

There are also good commit messages 😉

@dhh

This comment has been minimized.

Show comment
Hide comment
@dhh

dhh Mar 13, 2012

Member

Wups, didn't get the change removed here, see e7d55f7

Member

dhh replied Mar 13, 2012

Wups, didn't get the change removed here, see e7d55f7

Please sign in to comment.