Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Ensure AutosaveAssociation runs remove callbacks [#2146 state:resolved]
Signed-off-by: Eloy Duran <eloy.de.enige@gmail.com> Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
- Loading branch information
Showing
7 changed files
with
185 additions
and
21 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Original file line | Diff line number | Diff line change |
---|---|---|---|
@@ -1,16 +1,63 @@ | |||
class Pirate < ActiveRecord::Base | class Pirate < ActiveRecord::Base | ||
belongs_to :parrot | belongs_to :parrot | ||
has_and_belongs_to_many :parrots | has_and_belongs_to_many :parrots | ||
has_many :treasures, :as => :looter | has_and_belongs_to_many :parrots_with_method_callbacks, :class_name => "Parrot", | ||
:before_add => :log_before_add, | |||
:after_add => :log_after_add, | |||
:before_remove => :log_before_remove, | |||
:after_remove => :log_after_remove | |||
has_and_belongs_to_many :parrots_with_proc_callbacks, :class_name => "Parrot", | |||
:before_add => proc {|p,pa| p.ship_log << "before_adding_proc_parrot_#{pa.id || '<new>'}"}, | |||
:after_add => proc {|p,pa| p.ship_log << "after_adding_proc_parrot_#{pa.id || '<new>'}"}, | |||
:before_remove => proc {|p,pa| p.ship_log << "before_removing_proc_parrot_#{pa.id}"}, | |||
:after_remove => proc {|p,pa| p.ship_log << "after_removing_proc_parrot_#{pa.id}"} | |||
|
|
||
has_many :treasures, :as => :looter | |||
has_many :treasure_estimates, :through => :treasures, :source => :price_estimates | has_many :treasure_estimates, :through => :treasures, :source => :price_estimates | ||
|
|
||
# These both have :autosave enabled because accepts_nested_attributes_for is used on them. | # These both have :autosave enabled because accepts_nested_attributes_for is used on them. | ||
has_one :ship | has_one :ship | ||
has_many :birds | has_many :birds | ||
has_many :birds_with_method_callbacks, :class_name => "Bird", | |||
:before_add => :log_before_add, | |||
:after_add => :log_after_add, | |||
:before_remove => :log_before_remove, | |||
:after_remove => :log_after_remove | |||
has_many :birds_with_proc_callbacks, :class_name => "Bird", | |||
:before_add => proc {|p,b| p.ship_log << "before_adding_proc_bird_#{b.id || '<new>'}"}, | |||
:after_add => proc {|p,b| p.ship_log << "after_adding_proc_bird_#{b.id || '<new>'}"}, | |||
:before_remove => proc {|p,b| p.ship_log << "before_removing_proc_bird_#{b.id}"}, | |||
:after_remove => proc {|p,b| p.ship_log << "after_removing_proc_bird_#{b.id}"} | |||
|
|
||
accepts_nested_attributes_for :parrots, :birds, :allow_destroy => true, :reject_if => proc { |attributes| attributes.empty? } | accepts_nested_attributes_for :parrots, :birds, :allow_destroy => true, :reject_if => proc { |attributes| attributes.empty? } | ||
accepts_nested_attributes_for :ship, :allow_destroy => true, :reject_if => proc { |attributes| attributes.empty? } | accepts_nested_attributes_for :ship, :allow_destroy => true, :reject_if => proc { |attributes| attributes.empty? } | ||
accepts_nested_attributes_for :parrots_with_method_callbacks, :parrots_with_proc_callbacks, | |||
:birds_with_method_callbacks, :birds_with_proc_callbacks, :allow_destroy => true | |||
|
|
||
validates_presence_of :catchphrase | validates_presence_of :catchphrase | ||
|
|||
def ship_log | |||
@ship_log ||= [] | |||
end | |||
|
|||
private | |||
def log_before_add(record) | |||
log(record, "before_adding_method") | |||
end | |||
|
|||
def log_after_add(record) | |||
log(record, "after_adding_method") | |||
end | |||
|
|||
def log_before_remove(record) | |||
log(record, "before_removing_method") | |||
end | |||
|
|||
def log_after_remove(record) | |||
log(record, "after_removing_method") | |||
end | |||
|
|||
def log(record, callback) | |||
ship_log << "#{callback}_#{record.class.name.downcase}_#{record.id || '<new>'}" | |||
end | |||
end | end |