Permalink
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Browse files
Revert "It's snowing!"
Loading branch information
@@ -538,7 +538,7 @@ def html_options_for_form(url_for_options, options, *parameters_for_url)
def extra_tags_for_form ( html_options )
snowman_tag = tag ( :input , :type => "hidden" ,
:name => "_utf8 " , :value => "☃ ;" . html_safe )
:name => "utf8 " , :value => "✓ ;" . html_safe )
method = html_options . delete ( "method" ) . to_s
@@ -1513,7 +1513,7 @@ def test_form_for_with_labelled_builder
def snowman ( method = nil )
txt = %{<div style="margin:0;padding:0;display:inline">}
txt << %{<input name="_utf8 " type="hidden" value="☃ ;" />}
txt << %{<input name="utf8 " type="hidden" value="✓ ;" />}
txt << %{<input name="_method" type="hidden" value="#{ method } " />} if method
txt << %{</div>}
end
@@ -12,7 +12,7 @@ def snowman(options = {})
method = options [ :method ]
txt = %{<div style="margin:0;padding:0;display:inline">}
txt << %{<input name="_utf8 " type="hidden" value="☃ ;" />}
txt << %{<input name="utf8 " type="hidden" value="✓ ;" />}
txt << %{<input name="_method" type="hidden" value="#{ method } " />} if method
txt << %{</div>}
end
Toggle all file notes
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session.
You signed out in another tab or window. Reload to refresh your session.
This comment has been minimized.
:(☃
This comment has been minimized.
sometimes it is snowing, sometimes it is not snowing..
this is life!
This comment has been minimized.
:) ✓
This comment has been minimized.
It's funny how the reverted commit ends with "dead".
This comment has been minimized.
Oh come on that's starting to get really boring. Please discuss this in a small comitee (like ... the core team ...), decide something and keep to it.
This comment has been minimized.
Whatever the icon is, please use utf8 ( denotes special meaning!)
This comment has been minimized.
This snowman is a quite fickle creature...
This comment has been minimized.
dmathieu and KieranP +1.
All this joke lasted too long, I hope everybody will move on to more serious things. Just restore the underscore before the parameter.
This comment has been minimized.
I submited a patch on lighthouse to use _utf8
Any specific reason to use 'utf8' instead?
This comment has been minimized.
Here: https://rails.lighthouseapp.com/projects/8994/tickets/5367-rename-utf8-to-_utf8-old-snowman
This comment has been minimized.
This demands it's own book at some point.
This comment has been minimized.
0.o
This comment has been minimized.
consider this a the biggest easter egg of all time - now I could compare 'snowman' with dopefish
This comment has been minimized.
Yehuda - sorry to revisit this one (again).
Does this final commit mean that the TODO in actionpack/lib/action_dispatch/http/parameters.rb:40 is now done?