Permalink
Browse files

Revert "It's snowing!"

This reverts commit e428300.
  • Loading branch information...
wycats committed Aug 18, 2010
1 parent e4f424d commit 483b60b9ff2b467c9d4f4892ef1d5b68c95793d8
@@ -538,7 +538,7 @@ def html_options_for_form(url_for_options, options, *parameters_for_url)
def extra_tags_for_form(html_options)
snowman_tag = tag(:input, :type => "hidden",
:name => "_utf8", :value => "☃".html_safe)
:name => "utf8", :value => "✓".html_safe)
method = html_options.delete("method").to_s
@@ -1513,7 +1513,7 @@ def test_form_for_with_labelled_builder
def snowman(method = nil)
txt = %{<div style="margin:0;padding:0;display:inline">}
txt << %{<input name="_utf8" type="hidden" value="&#9731;" />}
txt << %{<input name="utf8" type="hidden" value="&#x2713;" />}
txt << %{<input name="_method" type="hidden" value="#{method}" />} if method
txt << %{</div>}
end
@@ -12,7 +12,7 @@ def snowman(options = {})
method = options[:method]
txt = %{<div style="margin:0;padding:0;display:inline">}
txt << %{<input name="_utf8" type="hidden" value="&#9731;" />}
txt << %{<input name="utf8" type="hidden" value="&#x2713;" />}
txt << %{<input name="_method" type="hidden" value="#{method}" />} if method
txt << %{</div>}
end

14 comments on commit 483b60b

@will

This comment has been minimized.

Show comment
Hide comment
@will

will replied Aug 19, 2010

:( ☃

@bernardeli

This comment has been minimized.

Show comment
Hide comment
@bernardeli

bernardeli Aug 19, 2010

sometimes it is snowing, sometimes it is not snowing..

this is life!

bernardeli replied Aug 19, 2010

sometimes it is snowing, sometimes it is not snowing..

this is life!

@jasontorres

This comment has been minimized.

Show comment
Hide comment
@jasontorres

jasontorres replied Aug 19, 2010

:) ✓

@adrianpacala

This comment has been minimized.

Show comment
Hide comment
@adrianpacala

adrianpacala Aug 19, 2010

Contributor

It's funny how the reverted commit ends with "dead".

Contributor

adrianpacala replied Aug 19, 2010

It's funny how the reverted commit ends with "dead".

@dmathieu

This comment has been minimized.

Show comment
Hide comment
@dmathieu

dmathieu Aug 19, 2010

Contributor

Oh come on that's starting to get really boring. Please discuss this in a small comitee (like ... the core team ...), decide something and keep to it.

Contributor

dmathieu replied Aug 19, 2010

Oh come on that's starting to get really boring. Please discuss this in a small comitee (like ... the core team ...), decide something and keep to it.

@KieranP

This comment has been minimized.

Show comment
Hide comment
@KieranP

KieranP Aug 19, 2010

Whatever the icon is, please use utf8 ( denotes special meaning!)

KieranP replied Aug 19, 2010

Whatever the icon is, please use utf8 ( denotes special meaning!)

@fsvehla

This comment has been minimized.

Show comment
Hide comment
@fsvehla

fsvehla Aug 19, 2010

This snowman is a quite fickle creature...

fsvehla replied Aug 19, 2010

This snowman is a quite fickle creature...

@nicolasblanco

This comment has been minimized.

Show comment
Hide comment
@nicolasblanco

nicolasblanco Aug 19, 2010

Contributor

dmathieu and KieranP +1.
All this joke lasted too long, I hope everybody will move on to more serious things. Just restore the underscore before the parameter.

Contributor

nicolasblanco replied Aug 19, 2010

dmathieu and KieranP +1.
All this joke lasted too long, I hope everybody will move on to more serious things. Just restore the underscore before the parameter.

@sobrinho

This comment has been minimized.

Show comment
Hide comment
@sobrinho

sobrinho Aug 19, 2010

Contributor

I submited a patch on lighthouse to use _utf8

Any specific reason to use 'utf8' instead?

Contributor

sobrinho replied Aug 19, 2010

I submited a patch on lighthouse to use _utf8

Any specific reason to use 'utf8' instead?

@sobrinho

This comment has been minimized.

Show comment
Hide comment
@lardawge

This comment has been minimized.

Show comment
Hide comment
@lardawge

lardawge Aug 19, 2010

Contributor

This demands it's own book at some point.

Contributor

lardawge replied Aug 19, 2010

This demands it's own book at some point.

@grimen

This comment has been minimized.

Show comment
Hide comment
@grimen

grimen replied Aug 20, 2010

0.o

@ghost

This comment has been minimized.

Show comment
Hide comment
@ghost

ghost Aug 21, 2010

consider this a the biggest easter egg of all time - now I could compare 'snowman' with dopefish

ghost replied Aug 21, 2010

consider this a the biggest easter egg of all time - now I could compare 'snowman' with dopefish

@tilsammans

This comment has been minimized.

Show comment
Hide comment
@tilsammans

tilsammans Aug 27, 2010

Contributor

Yehuda - sorry to revisit this one (again).

Does this final commit mean that the TODO in actionpack/lib/action_dispatch/http/parameters.rb:40 is now done?

Contributor

tilsammans replied Aug 27, 2010

Yehuda - sorry to revisit this one (again).

Does this final commit mean that the TODO in actionpack/lib/action_dispatch/http/parameters.rb:40 is now done?

Please sign in to comment.