Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP
Browse files

Revert "It's snowing!"

This reverts commit e428300.
  • Loading branch information...
commit 483b60b9ff2b467c9d4f4892ef1d5b68c95793d8 1 parent e4f424d
@wycats wycats authored
View
2  actionpack/lib/action_view/helpers/form_tag_helper.rb
@@ -538,7 +538,7 @@ def html_options_for_form(url_for_options, options, *parameters_for_url)
def extra_tags_for_form(html_options)
snowman_tag = tag(:input, :type => "hidden",
- :name => "_utf8", :value => "☃".html_safe)
+ :name => "utf8", :value => "✓".html_safe)
method = html_options.delete("method").to_s
View
2  actionpack/test/template/form_helper_test.rb
@@ -1513,7 +1513,7 @@ def test_form_for_with_labelled_builder
def snowman(method = nil)
txt = %{<div style="margin:0;padding:0;display:inline">}
- txt << %{<input name="_utf8" type="hidden" value="&#9731;" />}
+ txt << %{<input name="utf8" type="hidden" value="&#x2713;" />}
txt << %{<input name="_method" type="hidden" value="#{method}" />} if method
txt << %{</div>}
end
View
2  actionpack/test/template/form_tag_helper_test.rb
@@ -12,7 +12,7 @@ def snowman(options = {})
method = options[:method]
txt = %{<div style="margin:0;padding:0;display:inline">}
- txt << %{<input name="_utf8" type="hidden" value="&#9731;" />}
+ txt << %{<input name="utf8" type="hidden" value="&#x2713;" />}
txt << %{<input name="_method" type="hidden" value="#{method}" />} if method
txt << %{</div>}
end

14 comments on commit 483b60b

@will

:( ☃

@bernardeli

sometimes it is snowing, sometimes it is not snowing..

this is life!

@jasontorres

:) ✓

@apacala

It's funny how the reverted commit ends with "dead".

@dmathieu
Collaborator

Oh come on that's starting to get really boring. Please discuss this in a small comitee (like ... the core team ...), decide something and keep to it.

@KieranP

Whatever the icon is, please use _utf8 (_ denotes special meaning!)

@fsvehla

This snowman is a quite fickle creature...

@nicolasblanco

dmathieu and KieranP +1.
All this joke lasted too long, I hope everybody will move on to more serious things. Just restore the underscore before the parameter.

@sobrinho

I submited a patch on lighthouse to use _utf8

Any specific reason to use 'utf8' instead?

@lardawge

This demands it's own book at some point.

@grimen

0.o

@moonshine

consider this a the biggest easter egg of all time - now I could compare 'snowman' with dopefish

@tilsammans

Yehuda - sorry to revisit this one (again).

Does this final commit mean that the TODO in actionpack/lib/action_dispatch/http/parameters.rb:40 is now done?

Please sign in to comment.
Something went wrong with that request. Please try again.