Skip to content
Browse files

Fixed that FormHelper#checkbox should return a checked checkbox if th…

…e value is the same as checked_value #1286 [Florian Weber]

git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1317 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
  • Loading branch information...
1 parent 47dcc5f commit 496ee0cd1b2840fcccfa2695b8489463a548cc34 @dhh dhh committed May 19, 2005
View
2 actionpack/CHANGELOG
@@ -1,5 +1,7 @@
*SVN*
+* Fixed that FormHelper#checkbox should return a checked checkbox if the value is the same as checked_value #1286 [Florian Weber]
+
* Fixed Form.disable in Prototype #1317 [Wintermute]
* Added accessors to logger, params, response, session, and headers from the view, so you can write <% logger.info "stuff" %> instead of <% @logger.info "others" %> -- more consistent with the preferred way of accessing these attributes and collections from the controller
View
2 actionpack/lib/action_view/helpers/form_helper.rb
@@ -200,6 +200,8 @@ def to_check_box_tag(options = {}, checked_value = "1", unchecked_value = "0")
false
when Integer
value != 0
+ when String
+ value == checked_value
else
value.to_i != 0
end
View
8 actionpack/test/template/form_helper_test.rb
@@ -80,6 +80,14 @@ def test_check_box
check_box("post", "secret")
)
end
+
+ def test_check_box_with_explicit_checked_and_unchecked_values
+ @post.secret = "on"
+ assert_equal(
+ '<input checked="checked" id="post_secret" name="post[secret]" type="checkbox" value="on" /><input name="post[secret]" type="hidden" value="off" />',
+ check_box("post", "secret", {}, "on", "off")
+ )
+ end
def test_radio_button
assert_equal('<input checked="checked" id="post_title_hello_world" name="post[title]" type="radio" value="Hello World" />',

0 comments on commit 496ee0c

Please sign in to comment.
Something went wrong with that request. Please try again.