From 363eec42e99716c896b1797f1fedc03bc30b841b Mon Sep 17 00:00:00 2001 From: Renan Gurgel Date: Mon, 23 Oct 2017 21:21:03 -0300 Subject: [PATCH 1/2] Space between { and | missing. Improve a code style recommendation following Rubocop instructions https://codeclimate.com/github/rails/rails/issues --- railties/lib/rails/generators/rails/plugin/plugin_generator.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/railties/lib/rails/generators/rails/plugin/plugin_generator.rb b/railties/lib/rails/generators/rails/plugin/plugin_generator.rb index 331e73d1f0a8..65a124b0b8a8 100644 --- a/railties/lib/rails/generators/rails/plugin/plugin_generator.rb +++ b/railties/lib/rails/generators/rails/plugin/plugin_generator.rb @@ -92,7 +92,7 @@ def test ] def generate_test_dummy(force = false) - opts = (options.dup || {}).keep_if {|k, | PASSTHROUGH_OPTIONS.map(&:to_s).include?(k) } + opts = (options.dup || {}).keep_if { |k, | PASSTHROUGH_OPTIONS.map(&:to_s).include?(k) } opts[:force] = force opts[:skip_bundle] = true opts[:skip_listen] = true From a4eed027411c7db1091d2fdc26135b67c9b985bd Mon Sep 17 00:00:00 2001 From: Renan Gurgel Date: Tue, 24 Oct 2017 10:19:29 -0300 Subject: [PATCH 2/2] add _ for unused last arg --- railties/lib/rails/generators/rails/plugin/plugin_generator.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/railties/lib/rails/generators/rails/plugin/plugin_generator.rb b/railties/lib/rails/generators/rails/plugin/plugin_generator.rb index 65a124b0b8a8..d9ca4712d072 100644 --- a/railties/lib/rails/generators/rails/plugin/plugin_generator.rb +++ b/railties/lib/rails/generators/rails/plugin/plugin_generator.rb @@ -92,7 +92,7 @@ def test ] def generate_test_dummy(force = false) - opts = (options.dup || {}).keep_if { |k, | PASSTHROUGH_OPTIONS.map(&:to_s).include?(k) } + opts = (options.dup || {}).keep_if { |k, _| PASSTHROUGH_OPTIONS.map(&:to_s).include?(k) } opts[:force] = force opts[:skip_bundle] = true opts[:skip_listen] = true