Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP
Browse files

Remove eval calls, use send.. eval is evil

  • Loading branch information...
commit 4af62c02ae3dd0738965b167fbf07940e5d64daf 1 parent 6a5408b
@carlosantoniodasilva carlosantoniodasilva authored
Showing with 3 additions and 3 deletions.
  1. +3 −3 actionpack/lib/action_view/helpers/form_options_helper.rb
View
6 actionpack/lib/action_view/helpers/form_options_helper.rb
@@ -334,7 +334,7 @@ def options_for_select(container, selected = nil)
end.join("\n").html_safe
end
- # Returns a string of option tags that have been compiled by iterating over the +collection+ and assigning
+ # Returns a string of option tags that have been compiled by iterating over the +collection+ and assigning
# the result of a call to the +value_method+ as the option value and the +text_method+ as the option text.
# Example:
# options_from_collection_for_select(@people, 'id', 'name')
@@ -418,9 +418,9 @@ def options_from_collection_for_select(collection, value_method, text_method, se
# wrap the output in an appropriate <tt><select></tt> tag.
def option_groups_from_collection_for_select(collection, group_method, group_label_method, option_key_method, option_value_method, selected_key = nil)
collection.map do |group|
- group_label_string = eval("group.#{group_label_method}")
+ group_label_string = group.send(group_label_method)
"<optgroup label=\"#{ERB::Util.html_escape(group_label_string)}\">" +
- options_from_collection_for_select(eval("group.#{group_method}"), option_key_method, option_value_method, selected_key) +
+ options_from_collection_for_select(group.send(group_method), option_key_method, option_value_method, selected_key) +
'</optgroup>'
end.join.html_safe
end
Please sign in to comment.
Something went wrong with that request. Please try again.