Permalink
Browse files

Don't use strings for callbacks, as these will be evaled. Rather use …

…symbols, which uses a direct method dispatch.

Patch by Comron Sattari. [#3429 state:resolved]
  • Loading branch information...
1 parent c48a71c commit 4b7a439bd17e6d9e8567758ee6a0da13447c3229 @alloy alloy committed Jan 1, 2010
Showing with 2 additions and 2 deletions.
  1. +2 −2 activerecord/lib/active_record/autosave_association.rb
@@ -164,8 +164,8 @@ def #{type}(name, options = {})
# guards that check if the save or validation methods have already been
# defined before actually defining them.
def add_autosave_association_callbacks(reflection)
- save_method = "autosave_associated_records_for_#{reflection.name}"
- validation_method = "validate_associated_records_for_#{reflection.name}"
+ save_method = :"autosave_associated_records_for_#{reflection.name}"
+ validation_method = :"validate_associated_records_for_#{reflection.name}"
force_validation = (reflection.options[:validate] == true || reflection.options[:autosave] == true)
if reflection.collection_association?

0 comments on commit 4b7a439

Please sign in to comment.