/rails

Permalink
Browse files

edit changelog to mention about x_sendfile_header default change

  • Loading branch information...
1 parent 8845ae6 commit 4cf94979c9f4d6683c9338d694d5eb3106a4e734 @vijaydev vijaydev committed Aug 7, 2011
Unified Split
Showing with 2 additions and 0 deletions.
  1. +2 −0 actionpack/CHANGELOG
View
2 actionpack/CHANGELOG
@@ -30,6 +30,8 @@
*Rails 3.1.0 (unreleased)*
+* x_sendfile_header now defaults to nil and config/environments/production.rb doesn't set a particular value for it. This allows servers to set it through X-Sendfile-Type. [Santiago Pastorino]
+
* The submit form helper does not generate an id "object_name_id" anymore. [fbrusatti]
* Make sure respond_with with :js tries to render a template in all cases [José Valim]

1 comment on commit 4cf9497

@tt

tt commented on 4cf9497 Jan 2, 2017

This commit effectively breaks the repository and prevents any Git client that performs integrity checks (e.g. by having fetch.fsckObjects enabled) from cloning it:

% git cat-file -p 4cf94979c9f4d6683c9338d694d5eb3106a4e734
...
author Vijay Dev <vijaydev.cse@gmail.com> 1312735823 +051800
committer Vijay Dev <vijaydev.cse@gmail.com> 1312735823 +051800
...

"+051800" is the problem:

% git fsck
...
error in commit 4cf94979c9f4d6683c9338d694d5eb3106a4e734: badTimezone: invalid author/committer line - bad time zone
...

There is not really a way to address this now but maybe it should be documented that to clone the repository, you must first disable such checks.
Please sign in to comment.