Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP
Browse files

Merge pull request #15100 from eileencodes/remove-deprecation-warning…

…-no-longer-needed

remove deprecation warning
  • Loading branch information...
commit 522110af700efa0fff203f5bbccb70f06a9e28ee 2 parents 348af15 + b342d2b
@chancancode chancancode authored
View
4 activesupport/CHANGELOG.md
@@ -1,3 +1,7 @@
+* Remove deprecated string based terminators for `ActiveSupport::Callbacks`.
+
+ *Eileen M. Uchitelle*
+
* Fixed an issue when using
`ActiveSupport::NumberHelper::NumberToDelimitedConverter` to
convert a value that is an `ActiveSupport::SafeBuffer` introduced
View
6 activesupport/lib/active_support/callbacks.rb
@@ -724,12 +724,6 @@ def reset_callbacks(name)
# would call <tt>Audit#save</tt>.
def define_callbacks(*names)
options = names.extract_options!
- if options.key?(:terminator) && String === options[:terminator]
- ActiveSupport::Deprecation.warn "String based terminators are deprecated, please use a lambda"
- value = options[:terminator]
- line = class_eval "lambda { |result| #{value} }", __FILE__, __LINE__
- options[:terminator] = lambda { |target, result| target.instance_exec(result, &line) }
- end
names.each do |name|
class_attribute "_#{name}_callbacks"
Please sign in to comment.
Something went wrong with that request. Please try again.