Permalink
Browse files

Added special case for "1 Byte" in NumberHelper#number_to_human_size (c…

…loses #5593) [murpyh@rubychan.de]

git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4537 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
  • Loading branch information...
dhh committed Jul 5, 2006
1 parent 4bd827e commit 532627452d0e581eb263499ccf84cf92f27de4d8
View
@@ -1,5 +1,7 @@
*SVN*
+* Added special case for "1 Byte" in NumberHelper#number_to_human_size #5593 [murpyh@rubychan.de]
+
* Fixed proper form-encoded parameter parsing for requests with "Content-Type: application/x-www-form-urlencoded; charset=utf-8" (note the presence of a charset directive) [DHH]
* Add route_name_path method to generate only the path for a named routes. For example, map.person will add person_path. [Nicholas Seckar]
@@ -3,7 +3,6 @@ module Helpers
# Provides methods for converting a number into a formatted string that currently represents
# one of the following forms: phone number, percentage, money, or precision level.
module NumberHelper
-
# Formats a +number+ into a US phone number string. The +options+ can be a hash used to customize the format of the output.
# The area code can be surrounded by parentheses by setting +:area_code+ to true; default is false
# The delimiter can be set using +:delimiter+; default is "-"
@@ -86,6 +85,7 @@ def number_with_delimiter(number, delimiter=",")
# human_size(1234567890) => 1.1 GB
def number_to_human_size(size)
case
+ when size == 1 : '1 Byte'
when size < 1.kilobyte: '%d Bytes' % size
when size < 1.megabyte: '%.1f KB' % (size / 1.0.kilobyte)
when size < 1.gigabyte: '%.1f MB' % (size / 1.0.megabyte)
@@ -35,6 +35,7 @@ def test_number_with_delimiter
def test_number_to_human_size
assert_equal '0 Bytes', human_size(0)
+ assert_equal '1 Byte', human_size(1)
assert_equal '3 Bytes', human_size(3.14159265)
assert_equal '123 Bytes', human_size(123.0)
assert_equal '123 Bytes', human_size(123)

0 comments on commit 5326274

Please sign in to comment.