Permalink
Browse files

Fixed that :get, :post, and the others should take a flash array as t…

…he third argument just like process #1144 [rails@cogentdude.com]

git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1227 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
  • Loading branch information...
1 parent 0dd4978 commit 5462358cd397583f3b4cfcdf2933b80dbc48d353 @dhh dhh committed Apr 19, 2005
View
@@ -1,5 +1,7 @@
*SVN*
+* Fixed that :get, :post, and the others should take a flash array as the third argument just like process #1144 [rails@cogentdude.com]
+
* Fixed a problem with Flash.now
* Fixed stringification on all assigned hashes. The sacrifice is that assigns[:person] won't work in testing. Instead assigns["person"] or assigns(:person) must be used. In other words, the keys of assigns stay strings but we've added a method-based accessor to appease the need for symbols.
@@ -258,9 +258,9 @@ def process(action, parameters = nil, session = nil, flash = nil)
# execute the request simulating a specific http method and set/volley the response
%w( get post put delete head ).each do |method|
class_eval <<-EOV
- def #{method}(action, parameters = nil, session = nil)
+ def #{method}(action, parameters = nil, session = nil, flash = nil)
@request.env['REQUEST_METHOD'] = "#{method.upcase}"
- process(action, parameters, session)
+ process(action, parameters, session, flash)
end
EOV
end
@@ -146,6 +146,9 @@ def clear_association_cache #:nodoc:
# Please note that because eager loading is fetching both models and associations in the same grab, it doesn't make sense to use the
# :limit property and it will be ignored if attempted.
#
+ # Also have in mind that since the eager loading is pulling from multiple tables, you'll have to disambiguate any column references
+ # in both conditions and orders. So :order => "posts.id DESC" will work while :order => "id DESC" will not.
+ #
# == Modules
#
# By default, associations will look for objects within the current module scope. Consider:

0 comments on commit 5462358

Please sign in to comment.