Simple fix for correctly inverting an add_index migration when a name…

… has been provided
rails · Aug 22, 2011 · 54866b0 · 54866b0
1 parent 5ec3430
commit 54866b0
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 2 deletions.
diff --git a/activerecord/lib/active_record/migration/command_recorder.rb b/activerecord/lib/active_record/migration/command_recorder.rb
@@ -79,8 +79,12 @@ def invert_rename_column(args)
       end
 
       def invert_add_index(args)
-        table, columns, _ = *args
+        table, columns, options = *args
-        [:remove_index, [table, {:column => columns}]]
+        if options && options[:name]
+          [:remove_index, [table, {:name => options[:name]}]]
+        else
+          [:remove_index, [table, {:column => columns}]]
+        end
       end
 
       def invert_remove_timestamps(args)

diff --git a/activerecord/test/cases/migration/command_recorder_test.rb b/activerecord/test/cases/migration/command_recorder_test.rb
@@ -91,6 +91,12 @@ def test_invert_add_index
         assert_equal [:remove_index, [:table, {:column => [:one, :two]}]], remove
       end
 
+      def test_invert_add_index_with_name
+          @recorder.record :add_index, [:table, [:one, :two], {:name => "new_index"}]
+          remove = @recorder.inverse.first
+          assert_equal [:remove_index, [:table, {:name => "new_index"}]], remove
+      end
+
       def test_invert_rename_index
         @recorder.record :rename_index, [:old, :new]
         rename = @recorder.inverse.first