Permalink
Browse files

Merge pull request #1750 from dmathieu/non_string_methods

Calling unsafe methods which don't return a string shouldn't fail
  • Loading branch information...
2 parents 53444b8 + 9fadf38 commit 5654f6870af3cfb7dd92a017e7f86ba40ebfd9bf @fxn fxn committed Jun 22, 2011
@@ -137,8 +137,8 @@ def to_yaml(*args)
UNSAFE_STRING_METHODS.each do |unsafe_method|
class_eval <<-EOT, __FILE__, __LINE__
- def #{unsafe_method}(*args)
- super.to_str
+ def #{unsafe_method}(*args, &block)
+ to_str.#{unsafe_method}(*args, &block)
end
def #{unsafe_method}!(*args)
@@ -104,4 +104,8 @@ def setup
@buffer.safe_concat "BUSTED"
end
end
+
+ test "should not fail if the returned object is not a string" do
+ assert_kind_of Enumerator, @buffer.gsub(/.*/)
+ end
end

0 comments on commit 5654f68

Please sign in to comment.