Permalink
Browse files

options should always be passed to url_for

  • Loading branch information...
1 parent 5953266 commit 567aa5440e3030161cb9dd0864909f1ccce60f72 @tenderlove tenderlove committed May 13, 2014
Showing with 2 additions and 2 deletions.
  1. +2 −2 actionpack/lib/action_dispatch/routing/route_set.rb
@@ -645,9 +645,9 @@ def _generate_prefix(options = {})
nil
end
- # The +options+ argument must be +nil+ or a hash whose keys are *symbols*.
+ # The +options+ argument must be a hash whose keys are *symbols*.
def url_for(options)
- options = default_url_options.merge(options || {})
+ options = default_url_options.merge options
user = password = nil

1 comment on commit 567aa54

@pixeltrix
Member

We did get at least one report about using nil with url_for - do we need to deprecate it?

Please sign in to comment.