Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP
Browse files

fix thread safety issues

this test case had a race condition where it could download data
multiple times.  We'll download the data once at class load.
  • Loading branch information...
commit 5737c8e24b022556e5e03629b3249a033c5cee72 1 parent 5751b7e
@tenderlove tenderlove authored
Showing with 7 additions and 4 deletions.
  1. +7 −4 activesupport/test/multibyte_conformance_test.rb
View
11 activesupport/test/multibyte_conformance_test.rb
@@ -21,6 +21,7 @@ def self.download(from, to)
end
end
end
+ true
end
end
@@ -30,13 +31,15 @@ class MultibyteConformanceTest < ActiveSupport::TestCase
UNIDATA_URL = "http://www.unicode.org/Public/#{ActiveSupport::Multibyte::Unicode::UNICODE_VERSION}/ucd"
UNIDATA_FILE = '/NormalizationTest.txt'
CACHE_DIR = File.join(Dir.tmpdir, 'cache')
+ FileUtils.mkdir_p(CACHE_DIR)
+ RUN_P = begin
+ Downloader.download(UNIDATA_URL + UNIDATA_FILE, CACHE_DIR + UNIDATA_FILE)
+ rescue
+ end
def setup
- FileUtils.mkdir_p(CACHE_DIR)
- Downloader.download(UNIDATA_URL + UNIDATA_FILE, CACHE_DIR + UNIDATA_FILE)
@proxy = ActiveSupport::Multibyte::Chars
- rescue
- skip "Unable to download test data"
+ skip "Unable to download test data" unless RUN_P
end
def test_normalizations_C
Please sign in to comment.
Something went wrong with that request. Please try again.