Permalink
Browse files

sprockets 2.9.x doesn't work with uglifier 2.0 yet.

  • Loading branch information...
1 parent a9da549 commit 575838795019f7402992e3bfa83a0c5048cf143d @rafaelfranca rafaelfranca committed Apr 6, 2013
Showing with 2 additions and 2 deletions.
  1. +2 −2 railties/lib/rails/generators/app_base.rb
@@ -186,15 +186,15 @@ def assets_gemfile_entry
gem 'sass-rails', github: 'rails/sass-rails'
# To use Uglifier as compressor for JavaScript assets
- gem 'uglifier', '>= 1.3.0'
+ gem 'uglifier', '~> 1.3'
GEMFILE
else
<<-GEMFILE.gsub(/^ {12}/, '')
# Use SCSS for stylesheets
gem 'sass-rails', '~> 4.0.0.beta1'
# To use Uglifier as compressor for JavaScript assets
- gem 'uglifier', '>= 1.3.0'
+ gem 'uglifier', '~> 1.3'
GEMFILE
end

7 comments on commit 5758387

Member

josh replied Apr 6, 2013

Uglifier API changes?

Seems like a reasonable expectation if they did a major version bump.

Owner

rafaelfranca replied Apr 6, 2013

Seems so. This commit should fix issues with new applications. Existing applications can have problems, though 😢

I don't know if you want to handle this on sprockets side. I just want to make sure you are aware of this change.

Member

josh replied Apr 6, 2013

I'll probably make an update to sprockets.

But a little annoying that Uglifier bombs if you pass it a now unsupported option.

Member

josh replied Apr 6, 2013

Added support for Uglifier 2.x in sstephenson/sprockets@04a059c. Also tagged 1.9.1.

Owner

rafaelfranca replied Apr 6, 2013

Thank you sir 🎩

❤️

Contributor

lautis replied Apr 6, 2013

@josh It's annoying, but IMHO better than silently corrupting JS because a compilation option wasn't applied. I've restored copyright option in Uglifier 2.0.1.

Sorry for breaking the build.

Member

josh replied Apr 6, 2013

Please sign in to comment.