fix rendering a partial with an array as its :object [#5746 state:res…

…olved] Signed-off-by: Michael Koziarski <michael@koziarski.com> Conflicts: actionpack/lib/action_view/render/partials.rb
rails · Oct 7, 2010 · 581b2b6 · 581b2b6
1 parent c776080
commit 581b2b6
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 3 deletions.
diff --git a/actionpack/lib/action_view/render/partials.rb b/actionpack/lib/action_view/render/partials.rb
@@ -235,7 +235,7 @@ def setup(options, block)
         else
           @object = partial
 
-          if @collection = collection
+          if @collection = collection_from_object || collection
             paths = @collection_data = @collection.map { |o| partial_path(o) }
             @path = paths.uniq.size == 1 ? paths.first : nil
           else
@@ -337,10 +337,14 @@ def render_partial
     private
 
       def collection
+        if @options.key?(:collection)
+          @options[:collection] || []
+        end
+      end
+
+      def collection_from_object
         if @object.respond_to?(:to_ary)
           @object
-        elsif @options.key?(:collection)
-          @options[:collection] || []
         end
       end
 

diff --git a/actionpack/test/fixtures/test/_object_inspector.erb b/actionpack/test/fixtures/test/_object_inspector.erb
@@ -0,0 +1 @@
+<%= object_inspector.inspect -%>
diff --git a/actionpack/test/template/render_test.rb b/actionpack/test/template/render_test.rb
@@ -127,6 +127,10 @@ def test_render_object
     assert_equal "Hello: david", @view.render(:partial => "test/customer", :object => Customer.new("david"))
   end
 
+  def test_render_object_with_array
+    assert_equal "[1, 2, 3]", @view.render(:partial => "test/object_inspector", :object => [1, 2, 3])
+  end
+
   def test_render_partial_collection
     assert_equal "Hello: davidHello: mary", @view.render(:partial => "test/customer", :collection => [ Customer.new("david"), Customer.new("mary") ])
   end