Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP
Browse files

rename Backend::Simple#add_translations to set_translations

because it overwrites existing translations
  • Loading branch information...
commit 585c8c17c303fc46fcf014a644a541eae6cb5ffd 1 parent b09c6e7
@svenfuchs svenfuchs authored
View
2  actionpack/lib/action_view/helpers/form_options_helper.rb
@@ -349,7 +349,7 @@ def option_value_selected?(value, selected)
end
# All the countries included in the country_options output.
- # only included for backwards compatibility, please use the I18n interface
+ # deprecated. please use :'countries.names'.t directly
COUNTRIES = :'countries.names'.t 'en-US' unless const_defined?("COUNTRIES")
end
View
2  actionpack/lib/action_view/lang/en-US.rb
@@ -1,4 +1,4 @@
-I18n.backend.add_translations :'en-US', {
+I18n.backend.set_translations :'en-US', {
:date => {
:formats => {
:default => "%Y-%m-%d",
View
2  actionpack/test/template/number_helper_i18n_test.rb
@@ -7,7 +7,7 @@ class NumberHelperI18nTests < Test::Unit::TestCase
def setup
@request = mock
@defaults = {:separator => ".", :unit => "$", :format => "%u%n", :delimiter => ",", :precision => 2}
- I18n.backend.add_translations 'en-US', :currency => {:format => @defaults}
+ I18n.backend.set_translations 'en-US', :currency => {:format => @defaults}
end
def test_number_to_currency_given_a_locale_it_does_not_check_request_for_locale
View
2  activerecord/lib/active_record/lang/en-US.rb
@@ -1,4 +1,4 @@
-I18n.backend.add_translations :'en-US', {
+I18n.backend.set_translations :'en-US', {
:active_record => {
:error_messages => {
:inclusion => "is not included in the list",
View
2  activerecord/lib/active_record/validations.rb
@@ -21,7 +21,7 @@ class Errors
class << self
def default_error_messages
- # TODO deprecate this?
+ # ActiveSupport::Deprecation.warn("ActiveRecord::Errors.default_error_messages has been deprecated. Please use :'active_record.error_messages'.t.")
:'active_record.error_messages'.t
end
end
View
80 activerecord/test/cases/validations_i18n_test.rb
@@ -6,7 +6,7 @@ class ActiveRecordValidationsI18nTests < Test::Unit::TestCase
def setup
reset_callbacks Topic
@topic = Topic.new
- I18n.backend.add_translations('en-US', :active_record => {:error_messages => {:custom => nil}})
+ I18n.backend.set_translations('en-US', :active_record => {:error_messages => {:custom => nil}})
end
def teardown
@@ -113,8 +113,8 @@ def test_validates_confirmation_of_generates_message_with_custom_default_message
end
def test_validates_confirmation_of_finds_custom_model_key_translation
- I18n.backend.add_translations 'en-US', :active_record => {:error_messages => {:custom => {:topic => {:title => {:confirmation => 'custom message'}}}}}
- I18n.backend.add_translations 'en-US', :active_record => {:error_messages => {:confirmation => 'global message'}}
+ I18n.backend.set_translations 'en-US', :active_record => {:error_messages => {:custom => {:topic => {:title => {:confirmation => 'custom message'}}}}}
+ I18n.backend.set_translations 'en-US', :active_record => {:error_messages => {:confirmation => 'global message'}}
Topic.validates_confirmation_of :title
@topic.title_confirmation = 'foo'
@@ -123,7 +123,7 @@ def test_validates_confirmation_of_finds_custom_model_key_translation
end
def test_validates_confirmation_of_finds_global_default_translation
- I18n.backend.add_translations 'en-US', :active_record => {:error_messages => {:confirmation => 'global message'}}
+ I18n.backend.set_translations 'en-US', :active_record => {:error_messages => {:confirmation => 'global message'}}
Topic.validates_confirmation_of :title
@topic.title_confirmation = 'foo'
@@ -147,8 +147,8 @@ def test_validates_acceptance_of_generates_message_with_custom_default_message
end
def test_validates_acceptance_of_finds_custom_model_key_translation
- I18n.backend.add_translations 'en-US', :active_record => {:error_messages => {:custom => {:topic => {:title => {:accepted => 'custom message'}}}}}
- I18n.backend.add_translations 'en-US', :active_record => {:error_messages => {:accepted => 'global message'}}
+ I18n.backend.set_translations 'en-US', :active_record => {:error_messages => {:custom => {:topic => {:title => {:accepted => 'custom message'}}}}}
+ I18n.backend.set_translations 'en-US', :active_record => {:error_messages => {:accepted => 'global message'}}
Topic.validates_acceptance_of :title, :allow_nil => false
@topic.valid?
@@ -156,7 +156,7 @@ def test_validates_acceptance_of_finds_custom_model_key_translation
end
def test_validates_acceptance_of_finds_global_default_translation
- I18n.backend.add_translations 'en-US', :active_record => {:error_messages => {:accepted => 'global message'}}
+ I18n.backend.set_translations 'en-US', :active_record => {:error_messages => {:accepted => 'global message'}}
Topic.validates_acceptance_of :title, :allow_nil => false
@topic.valid?
@@ -179,8 +179,8 @@ def test_validates_presence_of_generates_message_with_custom_default_message
end
def test_validates_presence_of_finds_custom_model_key_translation
- I18n.backend.add_translations 'en-US', :active_record => {:error_messages => {:custom => {:topic => {:title => {:blank => 'custom message'}}}}}
- I18n.backend.add_translations 'en-US', :active_record => {:error_messages => {:blank => 'global message'}}
+ I18n.backend.set_translations 'en-US', :active_record => {:error_messages => {:custom => {:topic => {:title => {:blank => 'custom message'}}}}}
+ I18n.backend.set_translations 'en-US', :active_record => {:error_messages => {:blank => 'global message'}}
Topic.validates_presence_of :title
@topic.valid?
@@ -188,7 +188,7 @@ def test_validates_presence_of_finds_custom_model_key_translation
end
def test_validates_presence_of_finds_global_default_translation
- I18n.backend.add_translations 'en-US', :active_record => {:error_messages => {:blank => 'global message'}}
+ I18n.backend.set_translations 'en-US', :active_record => {:error_messages => {:blank => 'global message'}}
Topic.validates_presence_of :title
@topic.valid?
@@ -211,8 +211,8 @@ def test_validates_length_of_within_generates_message_with_custom_default_messag
end
def test_validates_length_of_within_finds_custom_model_key_translation
- I18n.backend.add_translations 'en-US', :active_record => {:error_messages => {:custom => {:topic => {:title => {:too_short => 'custom message'}}}}}
- I18n.backend.add_translations 'en-US', :active_record => {:error_messages => {:too_short => 'global message'}}
+ I18n.backend.set_translations 'en-US', :active_record => {:error_messages => {:custom => {:topic => {:title => {:too_short => 'custom message'}}}}}
+ I18n.backend.set_translations 'en-US', :active_record => {:error_messages => {:too_short => 'global message'}}
Topic.validates_length_of :title, :within => 3..5
@topic.valid?
@@ -220,7 +220,7 @@ def test_validates_length_of_within_finds_custom_model_key_translation
end
def test_validates_length_of_within_finds_global_default_translation
- I18n.backend.add_translations 'en-US', :active_record => {:error_messages => {:too_short => 'global message'}}
+ I18n.backend.set_translations 'en-US', :active_record => {:error_messages => {:too_short => 'global message'}}
Topic.validates_length_of :title, :within => 3..5
@topic.valid?
@@ -243,8 +243,8 @@ def test_validates_length_of_is_generates_message_with_custom_default_message
end
def test_validates_length_of_within_finds_custom_model_key_translation
- I18n.backend.add_translations 'en-US', :active_record => {:error_messages => {:custom => {:topic => {:title => {:wrong_length => 'custom message'}}}}}
- I18n.backend.add_translations 'en-US', :active_record => {:error_messages => {:wrong_length => 'global message'}}
+ I18n.backend.set_translations 'en-US', :active_record => {:error_messages => {:custom => {:topic => {:title => {:wrong_length => 'custom message'}}}}}
+ I18n.backend.set_translations 'en-US', :active_record => {:error_messages => {:wrong_length => 'global message'}}
Topic.validates_length_of :title, :is => 5
@topic.valid?
@@ -252,7 +252,7 @@ def test_validates_length_of_within_finds_custom_model_key_translation
end
def test_validates_length_of_within_finds_global_default_translation
- I18n.backend.add_translations 'en-US', :active_record => {:error_messages => {:wrong_length => 'global message'}}
+ I18n.backend.set_translations 'en-US', :active_record => {:error_messages => {:wrong_length => 'global message'}}
Topic.validates_length_of :title, :is => 5
@topic.valid?
@@ -277,8 +277,8 @@ def test_validates_uniqueness_of_generates_message_with_custom_default_message
end
def test_validates_length_of_within_finds_custom_model_key_translation
- I18n.backend.add_translations 'en-US', :active_record => {:error_messages => {:custom => {:topic => {:title => {:wrong_length => 'custom message'}}}}}
- I18n.backend.add_translations 'en-US', :active_record => {:error_messages => {:wrong_length => 'global message'}}
+ I18n.backend.set_translations 'en-US', :active_record => {:error_messages => {:custom => {:topic => {:title => {:wrong_length => 'custom message'}}}}}
+ I18n.backend.set_translations 'en-US', :active_record => {:error_messages => {:wrong_length => 'global message'}}
Topic.validates_length_of :title, :is => 5
@topic.valid?
@@ -286,7 +286,7 @@ def test_validates_length_of_within_finds_custom_model_key_translation
end
def test_validates_length_of_within_finds_global_default_translation
- I18n.backend.add_translations 'en-US', :active_record => {:error_messages => {:wrong_length => 'global message'}}
+ I18n.backend.set_translations 'en-US', :active_record => {:error_messages => {:wrong_length => 'global message'}}
Topic.validates_length_of :title, :is => 5
@topic.valid?
@@ -311,8 +311,8 @@ def test_validates_format_of_generates_message_with_custom_default_message
end
def test_validates_format_of_finds_custom_model_key_translation
- I18n.backend.add_translations 'en-US', :active_record => {:error_messages => {:custom => {:topic => {:title => {:invalid => 'custom message'}}}}}
- I18n.backend.add_translations 'en-US', :active_record => {:error_messages => {:invalid => 'global message'}}
+ I18n.backend.set_translations 'en-US', :active_record => {:error_messages => {:custom => {:topic => {:title => {:invalid => 'custom message'}}}}}
+ I18n.backend.set_translations 'en-US', :active_record => {:error_messages => {:invalid => 'global message'}}
Topic.validates_format_of :title, :with => /^[1-9][0-9]*$/
@topic.valid?
@@ -320,7 +320,7 @@ def test_validates_format_of_finds_custom_model_key_translation
end
def test_validates_format_of_finds_global_default_translation
- I18n.backend.add_translations 'en-US', :active_record => {:error_messages => {:invalid => 'global message'}}
+ I18n.backend.set_translations 'en-US', :active_record => {:error_messages => {:invalid => 'global message'}}
Topic.validates_format_of :title, :with => /^[1-9][0-9]*$/
@topic.valid?
@@ -345,8 +345,8 @@ def test_validates_inclusion_of_generates_message_with_custom_default_message
end
def test_validates_inclusion_of_finds_custom_model_key_translation
- I18n.backend.add_translations 'en-US', :active_record => {:error_messages => {:custom => {:topic => {:title => {:inclusion => 'custom message'}}}}}
- I18n.backend.add_translations 'en-US', :active_record => {:error_messages => {:inclusion => 'global message'}}
+ I18n.backend.set_translations 'en-US', :active_record => {:error_messages => {:custom => {:topic => {:title => {:inclusion => 'custom message'}}}}}
+ I18n.backend.set_translations 'en-US', :active_record => {:error_messages => {:inclusion => 'global message'}}
Topic.validates_inclusion_of :title, :in => %w(a b c)
@topic.valid?
@@ -354,7 +354,7 @@ def test_validates_inclusion_of_finds_custom_model_key_translation
end
def test_validates_inclusion_of_finds_global_default_translation
- I18n.backend.add_translations 'en-US', :active_record => {:error_messages => {:inclusion => 'global message'}}
+ I18n.backend.set_translations 'en-US', :active_record => {:error_messages => {:inclusion => 'global message'}}
Topic.validates_inclusion_of :title, :in => %w(a b c)
@topic.valid?
@@ -379,8 +379,8 @@ def test_validates_exclusion_of_generates_message_with_custom_default_message
end
def test_validates_exclusion_of_finds_custom_model_key_translation
- I18n.backend.add_translations 'en-US', :active_record => {:error_messages => {:custom => {:topic => {:title => {:exclusion => 'custom message'}}}}}
- I18n.backend.add_translations 'en-US', :active_record => {:error_messages => {:exclusion => 'global message'}}
+ I18n.backend.set_translations 'en-US', :active_record => {:error_messages => {:custom => {:topic => {:title => {:exclusion => 'custom message'}}}}}
+ I18n.backend.set_translations 'en-US', :active_record => {:error_messages => {:exclusion => 'global message'}}
Topic.validates_exclusion_of :title, :in => %w(a b c)
@topic.title = 'a'
@@ -389,7 +389,7 @@ def test_validates_exclusion_of_finds_custom_model_key_translation
end
def test_validates_exclusion_of_finds_global_default_translation
- I18n.backend.add_translations 'en-US', :active_record => {:error_messages => {:exclusion => 'global message'}}
+ I18n.backend.set_translations 'en-US', :active_record => {:error_messages => {:exclusion => 'global message'}}
Topic.validates_exclusion_of :title, :in => %w(a b c)
@topic.title = 'a'
@@ -415,8 +415,8 @@ def test_validates_numericality_of_only_integer_generates_message_with_custom_de
end
def test_validates_numericality_of_only_integer_finds_custom_model_key_translation
- I18n.backend.add_translations 'en-US', :active_record => {:error_messages => {:custom => {:topic => {:title => {:not_a_number => 'custom message'}}}}}
- I18n.backend.add_translations 'en-US', :active_record => {:error_messages => {:not_a_number => 'global message'}}
+ I18n.backend.set_translations 'en-US', :active_record => {:error_messages => {:custom => {:topic => {:title => {:not_a_number => 'custom message'}}}}}
+ I18n.backend.set_translations 'en-US', :active_record => {:error_messages => {:not_a_number => 'global message'}}
Topic.validates_numericality_of :title, :only_integer => true
@topic.title = 'a'
@@ -425,7 +425,7 @@ def test_validates_numericality_of_only_integer_finds_custom_model_key_translati
end
def test_validates_numericality_of_only_integer_finds_global_default_translation
- I18n.backend.add_translations 'en-US', :active_record => {:error_messages => {:not_a_number => 'global message'}}
+ I18n.backend.set_translations 'en-US', :active_record => {:error_messages => {:not_a_number => 'global message'}}
Topic.validates_numericality_of :title, :only_integer => true
@topic.title = 'a'
@@ -451,8 +451,8 @@ def test_validates_numericality_of_odd_generates_message_with_custom_default_mes
end
def test_validates_numericality_of_odd_finds_custom_model_key_translation
- I18n.backend.add_translations 'en-US', :active_record => {:error_messages => {:custom => {:topic => {:title => {:odd => 'custom message'}}}}}
- I18n.backend.add_translations 'en-US', :active_record => {:error_messages => {:odd => 'global message'}}
+ I18n.backend.set_translations 'en-US', :active_record => {:error_messages => {:custom => {:topic => {:title => {:odd => 'custom message'}}}}}
+ I18n.backend.set_translations 'en-US', :active_record => {:error_messages => {:odd => 'global message'}}
Topic.validates_numericality_of :title, :only_integer => true, :odd => true
@topic.title = 0
@@ -461,7 +461,7 @@ def test_validates_numericality_of_odd_finds_custom_model_key_translation
end
def test_validates_numericality_of_odd_finds_global_default_translation
- I18n.backend.add_translations 'en-US', :active_record => {:error_messages => {:odd => 'global message'}}
+ I18n.backend.set_translations 'en-US', :active_record => {:error_messages => {:odd => 'global message'}}
Topic.validates_numericality_of :title, :only_integer => true, :odd => true
@topic.title = 0
@@ -487,8 +487,8 @@ def test_validates_numericality_of_odd_generates_message_with_custom_default_mes
end
def test_validates_numericality_of_less_than_finds_custom_model_key_translation
- I18n.backend.add_translations 'en-US', :active_record => {:error_messages => {:custom => {:topic => {:title => {:less_than => 'custom message'}}}}}
- I18n.backend.add_translations 'en-US', :active_record => {:error_messages => {:less_than => 'global message'}}
+ I18n.backend.set_translations 'en-US', :active_record => {:error_messages => {:custom => {:topic => {:title => {:less_than => 'custom message'}}}}}
+ I18n.backend.set_translations 'en-US', :active_record => {:error_messages => {:less_than => 'global message'}}
Topic.validates_numericality_of :title, :only_integer => true, :less_than => 0
@topic.title = 1
@@ -497,7 +497,7 @@ def test_validates_numericality_of_less_than_finds_custom_model_key_translation
end
def test_validates_numericality_of_less_than_finds_global_default_translation
- I18n.backend.add_translations 'en-US', :active_record => {:error_messages => {:less_than => 'global message'}}
+ I18n.backend.set_translations 'en-US', :active_record => {:error_messages => {:less_than => 'global message'}}
Topic.validates_numericality_of :title, :only_integer => true, :less_than => 0
@topic.title = 1
@@ -521,8 +521,8 @@ def test_validates_associated_generates_message_with_custom_default_message
end
def test_validates_associated_finds_custom_model_key_translation
- I18n.backend.add_translations 'en-US', :active_record => {:error_messages => {:custom => {:topic => {:replies => {:invalid => 'custom message'}}}}}
- I18n.backend.add_translations 'en-US', :active_record => {:error_messages => {:invalid => 'global message'}}
+ I18n.backend.set_translations 'en-US', :active_record => {:error_messages => {:custom => {:topic => {:replies => {:invalid => 'custom message'}}}}}
+ I18n.backend.set_translations 'en-US', :active_record => {:error_messages => {:invalid => 'global message'}}
Topic.validates_associated :replies
replied_topic.valid?
@@ -530,7 +530,7 @@ def test_validates_associated_finds_custom_model_key_translation
end
def test_validates_associated_finds_global_default_translation
- I18n.backend.add_translations 'en-US', :active_record => {:error_messages => {:invalid => 'global message'}}
+ I18n.backend.set_translations 'en-US', :active_record => {:error_messages => {:invalid => 'global message'}}
Topic.validates_associated :replies
replied_topic.valid?
View
2  activesupport/lib/active_support/lang/en-US.rb
@@ -1,4 +1,4 @@
-I18n.backend.add_translations :'en-US', {
+I18n.backend.set_translations :'en-US', {
:support => {
:array => {
:sentence_connector => 'and'
2  activesupport/lib/active_support/vendor/i18n-0.0.1
@@ -1 +1 @@
-Subproject commit 70ab0f3cc5921cc67e09741939a08b2582d707cb
+Subproject commit 1af3435539b4a0729c13d21c5df037a635fe98c1
Please sign in to comment.
Something went wrong with that request. Please try again.