Permalink
Browse files

Changed the default name of the input tag generated by FormTagHelper#…

…submit_tag from "submit" to "commit" so it doesnt clash with form.submit() calls in Javascript #1271

git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1456 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
  • Loading branch information...
1 parent 9113aa2 commit 5ba31b3d1dc7a3ac1e69a799ce3400a09cc5dbdb @dhh dhh committed Jun 21, 2005
Showing with 3 additions and 1 deletion.
  1. +2 −0 actionpack/CHANGELOG
  2. +1 −1 actionpack/lib/action_view/helpers/form_tag_helper.rb
@@ -1,5 +1,7 @@
*SVN*
+* Changed the default name of the input tag generated by FormTagHelper#submit_tag from "submit" to "commit" so it doesn't clash with form.submit() calls in Javascript #1271
+
* Fixed relative urls support for lighttpd #1048 [Nicholas Seckar/maznawak@nerim.net]
* Correct distance_of_time_in_words for integer arguments and make the second arg optional, treating the first arg as a duration in seconds. #1458 [madrobby <thomas@fesch.at>]
@@ -76,7 +76,7 @@ def radio_button_tag(name, value, checked = false, options = {})
end
def submit_tag(value = "Save changes", options = {})
- tag("input", { "type" => "submit", "name" => "submit", "value" => value }.update(convert_options(options)))
+ tag("input", { "type" => "submit", "name" => "commit", "value" => value }.update(convert_options(options)))
end
def image_submit_tag(source, options = {})

0 comments on commit 5ba31b3

Please sign in to comment.