Permalink
Browse files

Skip broken asset precompilation test on Macs. Issues with NFD vs NFC…

… normalization on the asset filename. Major red flag with asset lookups!
  • Loading branch information...
1 parent 51550ed commit 5d183461c0dc0e0d7065352b2301a30430a5ff67 @jeremy jeremy committed Oct 8, 2011
Showing with 8 additions and 4 deletions.
  1. +8 −4 railties/test/application/assets_test.rb
@@ -289,16 +289,20 @@ class ::PostsController < ActionController::Base ; end
end
test "precompile should handle utf8 filenames" do
- app_file "app/assets/images/レイルズ.png", "not a image really"
+ if `uname` =~ /Darwin/
+ skip 'Asset lookup with Unicode filenames is a problematic due to different normalization forms. Mac uses NKD for filenames; Windows and Linux use NFC. So your asset lookups may mysteriously fail. Sprockets should handle these platform issues transparently.'
+ end
+
+ filename = "レイルズ.png"
+ app_file "app/assets/images/#{filename}", "not a image really"
add_to_config "config.assets.precompile = [ /\.png$$/, /application.(css|js)$/ ]"
precompile!
- assert File.exists?("#{app_path}/public/assets/レイルズ.png")
+ assert File.exists?("#{app_path}/public/assets/#{filename}")
manifest = "#{app_path}/public/assets/manifest.yml"
-
assets = YAML.load_file(manifest)
- assert_equal "レイルズ.png", assets["レイルズ.png"]
+ assert_equal filename, assets[filename], assets.inspect
end
test "assets are cleaned up properly" do

0 comments on commit 5d18346

Please sign in to comment.