Revert "Allow loading external route files from the router" · 5e7d6bb · rails/rails

henrik · July 02, 2012

@josevalim What do you mean by "Usage of this feature did not reveal any improvement in existing apps."? Compared to doing it manually, without special framework support?

I've found it useful to split routes into multiple files on larger projects, but IIRC it was easy enough with just multiple My::Application.routes.draw or instance_eval or something.

rafaelfranca · July 02, 2012

This was reverted in favor of https://github.com/rails/routing_concerns, that we think is a better approach.

henrik · July 02, 2012

@rafaelfranca Thanks! I don't see from the README how routing_concerns does anything to help split up routes, though – how would you go about that?

steveklabnik · July 02, 2012

The point of 'splitting up routes' was to make the routes file easier to read. routing_concerns will (hopefully) DRY up your routes so that you don't need to split them up anymore.

henrik · July 02, 2012

@steveklabnik Alright, thanks!

kuraga · July 03, 2012

But Rails makes possible to split much: locales, migrations... It's useful for spliting-up-by-components very much!

kuraga · July 09, 2012

@steveklabnik amn't I right (see previous message)?

steveklabnik · July 09, 2012

I don't know if you're right or not. Personally, I never tried this feature. @dhh didn't find it very helpful.

atrauzzi · March 28, 2014

Are there any examples of this new approach to defining multiple routes? Rails 4 docs make it look like concerns can only be used to modify existing routes...?

robin850 · March 30, 2014

Rails 4 docs make it look like concerns can only be used to modify existing routes...?

Actually concern routes are provided for DRY concerns, this is not really an alternative to the reverted patch here. I guess there is no equivalent at the time being but I may be wrong. It looks like this is not so hard to implement such feature inside your application.

dhh · March 30, 2014

I tried it out in practice and found that it made things more opaque, not clearer like I expected. So not something we want to encourage. If you need it, it's very easy to do on your own.

…

atrauzzi · April 01, 2014

Agreed, especially if the language already supports it, no need to try and over-systemize it. I think I've got something figured out.

@@ -1316,22 +1316,6 @@ def shallow?
                    parent_resource.instance_of?(Resource) && @scope[:shallow]
                  end
         -        def draw(name)
         -          path = @draw_paths.find do |_path|
         -            File.exists? "#{_path}/#{name}.rb"
         -          end
         -
         -          unless path
         -            msg  = "Your router tried to #draw the external file #{name}.rb,\n" \
         -                   "but the file was not found in:\n\n"
         -            msg += @draw_paths.map { |_path| " * #{_path}" }.join("\n")
         -            raise ArgumentError, msg
         -          end
         -
         -          route_path = "#{path}/#{name}.rb"
         -          instance_eval(File.read(route_path), route_path.to_s)
         -        end
         -
                  # match 'path' => 'controller#action'
                  # match 'path', to: 'controller#action'
                  # match 'path', 'otherpath', on: :member, via: :get
@@ -1581,7 +1565,6 @@ def name_for_action(as, action) #:nodoc:
                def initialize(set) #:nodoc:
                  @set = set
         -        @draw_paths = set.draw_paths
                  @scope = { :path_names => @set.resources_path_names }
                end

@@ -237,7 +237,6 @@ def optimized_helper(route)
                attr_accessor :formatter, :set, :named_routes, :default_scope, :router
                attr_accessor :disable_clear_and_finalize, :resources_path_names
                attr_accessor :default_url_options, :request_class, :valid_conditions
         -      attr_accessor :draw_paths
                alias :routes :set
@@ -249,7 +248,6 @@ def initialize(request_class = ActionDispatch::Request)
                  self.named_routes = NamedRouteCollection.new
                  self.resources_path_names = self.class.default_resources_path_names.dup
                  self.default_url_options = {}
         -        self.draw_paths = []
                  self.request_class = request_class
                  @valid_conditions = { :controller => true, :action => true }

@@ -845,24 +845,6 @@ end
          This will create routing helpers such as +magazine_periodical_ads_url+ and +edit_magazine_periodical_ad_path+.
         -h3. Breaking Up a Large Route File
         -
         -If you have a large route file that you would like to break up into multiple files, you can use the +#draw+ method in your router:
         -
         -<ruby>
         -draw :admin
         -</ruby>
         -
         -Then, create a file called +config/routes/admin.rb+. Name the file the same as the symbol passed to the +draw+ method. You can then use the normal routing DSL inside that file:
         -
         -<ruby>
         -# in config/routes/admin.rb
         -
         -namespace :admin do
         -  resources :posts
         -end
         -</ruby>
         -
          h3. Inspecting and Testing Routes
          Rails offers facilities for inspecting and testing your routes.

@@ -3,13 +3,12 @@
          module Rails
            class Application
              class RoutesReloader
         -      attr_reader :route_sets, :paths, :external_routes
         +      attr_reader :route_sets, :paths
                delegate :execute_if_updated, :execute, :updated?, :to => :updater
                def initialize
         -        @paths           = []
         -        @route_sets      = []
         -        @external_routes = []
         +        @paths      = []
         +        @route_sets = []
                end
                def reload!
@@ -24,11 +23,7 @@ def reload!
                def updater
                  @updater ||= begin
         -          dirs = @external_routes.each_with_object({}) do |dir, hash|
         -            hash[dir.to_s] = %w(rb)
         -          end
         -
         -          updater = ActiveSupport::FileUpdateChecker.new(paths, dirs) { reload! }
         +          updater = ActiveSupport::FileUpdateChecker.new(paths) { reload! }
                    updater.execute
                    updater
                  end

@@ -508,10 +508,7 @@ def env_config
              # Defines the routes for this engine. If a block is given to
              # routes, it is appended to the engine.
              def routes
         -      @routes ||= ActionDispatch::Routing::RouteSet.new.tap do |routes|
         -        routes.draw_paths.concat paths["config/routes"].paths
         -      end
         -
         +      @routes ||= ActionDispatch::Routing::RouteSet.new
                @routes.append(&Proc.new) if block_given?
                @routes
              end
@@ -555,12 +552,10 @@ def load_seed
              initializer :add_routing_paths do |app|
                paths = self.paths["config/routes.rb"].existent
         -      external_paths = self.paths["config/routes"].paths
                if routes? || paths.any?
                  app.routes_reloader.paths.unshift(*paths)
                  app.routes_reloader.route_sets << routes
         -        app.routes_reloader.external_routes.unshift(*external_paths)
                end
              end

public rails/rails

HTTPS clone URL

Subversion checkout URL

12 notes on commit `5e7d6bb`

public rails/rails

HTTPS clone URL

Subversion checkout URL

12 notes on commit 5e7d6bb

12 notes on commit `5e7d6bb`