Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP
Browse files

Fix Hash#from_xml with Type records. Closes #9242 [Juanjo Bazan, Isaa…

…c Feliu]

git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8937 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
  • Loading branch information...
commit 5e836127663f96ef6597f7dcdac3d14cc052fce3 1 parent 8352287
@jeremy jeremy authored
View
49 actionpack/test/controller/webservice_test.rb
@@ -56,16 +56,61 @@ def test_post_xml
assert_equal 'content...', @controller.params["entry"]['summary']
assert_equal 'true', @controller.params["entry"]['attributed']
end
-
+
def test_put_xml
process('PUT', 'application/xml', '<entry attributed="true"><summary>content...</summary></entry>')
-
+
assert_equal 'entry', @controller.response.body
assert @controller.params.has_key?(:entry)
assert_equal 'content...', @controller.params["entry"]['summary']
assert_equal 'true', @controller.params["entry"]['attributed']
end
+ def test_put_xml_using_a_type_node
+ process('PUT', 'application/xml', '<type attributed="true"><summary>content...</summary></type>')
+
+ assert_equal 'type', @controller.response.body
+ assert @controller.params.has_key?(:type)
+ assert_equal 'content...', @controller.params["type"]['summary']
+ assert_equal 'true', @controller.params["type"]['attributed']
+ end
+
+ def test_put_xml_using_a_type_node_and_attribute
+ process('PUT', 'application/xml', '<type attributed="true"><summary type="boolean">false</summary></type>')
+
+ assert_equal 'type', @controller.response.body
+ assert @controller.params.has_key?(:type)
+ assert_equal false, @controller.params["type"]['summary']
+ assert_equal 'true', @controller.params["type"]['attributed']
+ end
+
+ def test_post_xml_using_a_type_node
+ process('POST', 'application/xml', '<font attributed="true"><type>arial</type></font>')
+
+ assert_equal 'font', @controller.response.body
+ assert @controller.params.has_key?(:font)
+ assert_equal 'arial', @controller.params['font']['type']
+ assert_equal 'true', @controller.params["font"]['attributed']
+ end
+
+ def test_post_xml_using_a_root_node_named_type
+ process('POST', 'application/xml', '<type type="integer">33</type>')
+
+ assert @controller.params.has_key?(:type)
+ assert_equal 33, @controller.params['type']
+ end
+
+ def test_post_xml_using_an_attributted_node_named_type
+ ActionController::Base.param_parsers[Mime::XML] = Proc.new { |data| XmlSimple.xml_in(data, 'ForceArray' => false) }
+ process('POST', 'application/xml', '<request><type type="string">Arial,12</type><z>3</z></request>')
+
+ assert_equal 'type, z', @controller.response.body
+ assert @controller.params.has_key?(:type)
+ assert_equal 'string', @controller.params['type']['type']
+ assert_equal 'Arial,12', @controller.params['type']['content']
+ assert_equal '3', @controller.params['z']
+ end
+
def test_register_and_use_yaml
ActionController::Base.param_parsers[Mime::YAML] = Proc.new { |d| YAML.load(d) }
process('POST', 'application/x-yaml', {"entry" => "loaded from yaml"}.to_yaml)
View
5 activesupport/lib/active_support/core_ext/hash/conversions.rb
@@ -211,8 +211,9 @@ def typecast_xml_value(value)
elsif value.blank? || value['nil'] == 'true'
nil
# If the type is the only element which makes it then
- # this still makes the value nil
- elsif value['type'] && value.size == 1
+ # this still makes the value nil, except if type is
+ # a xml node(where type['value'] is a Hash)
+ elsif value['type'] && value.size == 1 && !value['type'].is_a?(::Hash)
nil
else
xml_value = value.inject({}) do |h,(k,v)|
Please sign in to comment.
Something went wrong with that request. Please try again.