Skip to content

Commit

Permalink
fixed non matching documentation behaviour with method semantics on d…
Browse files Browse the repository at this point in the history
…istance_of_time_in_words
  • Loading branch information
marceloeloelo authored and avakhov committed Apr 24, 2012
1 parent ff5b0d6 commit 5fdd4cd
Show file tree
Hide file tree
Showing 2 changed files with 20 additions and 3 deletions.
2 changes: 1 addition & 1 deletion actionpack/lib/action_view/helpers/date_helper.rb
Expand Up @@ -68,7 +68,7 @@ def distance_of_time_in_words(from_time, to_time = 0, include_seconds = false, o
from_time = from_time.to_time if from_time.respond_to?(:to_time)
to_time = to_time.to_time if to_time.respond_to?(:to_time)
from_time, to_time = to_time, from_time if from_time > to_time
distance_in_minutes = ((to_time - from_time)/60).round
distance_in_minutes = ((to_time - from_time)/60.0).round
distance_in_seconds = (to_time - from_time).round

I18n.with_options :locale => options[:locale], :scope => :'datetime.distance_in_words' do |locale|
Expand Down
21 changes: 19 additions & 2 deletions actionpack/test/template/date_helper_test.rb
Expand Up @@ -129,12 +129,29 @@ def test_distance_in_words_with_dates
end

def test_distance_in_words_with_integers
assert_equal "less than a minute", distance_of_time_in_words(59)
assert_equal "1 minute", distance_of_time_in_words(59)
assert_equal "about 1 hour", distance_of_time_in_words(60*60)
assert_equal "less than a minute", distance_of_time_in_words(0, 59)
assert_equal "1 minute", distance_of_time_in_words(0, 59)
assert_equal "about 1 hour", distance_of_time_in_words(60*60, 0)
end

def test_distance_in_words_with_times
assert_equal "1 minute", distance_of_time_in_words(30.seconds)
assert_equal "1 minute", distance_of_time_in_words(59.seconds)
assert_equal "2 minutes", distance_of_time_in_words(119.seconds)
assert_equal "2 minutes", distance_of_time_in_words(1.minute + 59.seconds)
assert_equal "3 minutes", distance_of_time_in_words(2.minute + 30.seconds)
assert_equal "44 minutes", distance_of_time_in_words(44.minutes + 29.seconds)
assert_equal "about 1 hour", distance_of_time_in_words(44.minutes + 30.seconds)
assert_equal "about 1 hour", distance_of_time_in_words(60.minutes)

# include seconds
assert_equal "half a minute", distance_of_time_in_words(39.seconds, 0, true)
assert_equal "less than a minute", distance_of_time_in_words(40.seconds, 0, true)
assert_equal "less than a minute", distance_of_time_in_words(59.seconds, 0, true)
assert_equal "1 minute", distance_of_time_in_words(60.seconds, 0, true)
end

def test_time_ago_in_words
assert_equal "about 1 year", time_ago_in_words(1.year.ago - 1.day)
end
Expand Down

0 comments on commit 5fdd4cd

Please sign in to comment.