Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP
Browse files

Whitespaces :scissors: [ci skip]

  • Loading branch information...
commit 623f2fbb933994bb81187c18984ae51047d9b029 1 parent d0d02bf
@rafaelfranca rafaelfranca authored
View
23 actionpack/CHANGELOG.md
@@ -1,20 +1,23 @@
## Rails 4.0.0 (unreleased) ##
-* `assert_template` no more passing with what ever string that matches.
-
- Given Im rendering an template `/layout/hello.html.erb`, assert_template was
- passing with any string that matches. This behavior allowed false passing like:
+* `assert_template` is no more passing with what ever string that matches
+ with the template name.
- assert_template "layout"
- assert_template "out/hello"
+ Before when we have a template `/layout/hello.html.erb`, `assert_template`
+ was passing with any string that matches. This behavior allowed false
+ positive like:
- Now the passing possibilities are:
+ assert_template "layout"
+ assert_template "out/hello"
- assert_template "layout/hello"
- assert_template "hello"
+ Now it only passes with:
- *Hugolnx*
+ assert_template "layout/hello"
+ assert_template "hello"
+
+ Fixes #3849.
+ *Hugolnx*
* `image_tag` will set the same width and height for image if numerical value
passed to `size` option.
View
2  actionpack/lib/action_controller/test_case.rb
@@ -91,7 +91,7 @@ def assert_template(options = {}, message = nil)
rendered = @templates
msg = message || sprintf("expecting <%s> but rendering with <%s>",
options.inspect, rendered.keys)
- matches_template =
+ matches_template =
case options
when String
rendered.any? do |t, num|
Please sign in to comment.
Something went wrong with that request. Please try again.