Permalink
Browse files

ActiveRecord::Base#<=> has been removed. Primary keys may not be in o…

…rder,

or even be numbers, so sorting by id doesn't make sense.  Please use `sort_by`
and specify the attribute you wish to sort with.  For example, change:

  Post.all.to_a.sort

to:

  Post.all.to_a.sort_by(&:id)
  • Loading branch information...
1 parent 096a57b commit 6256734e2d0bdd89f4b5d11da259d40afa0c95c7 @tenderlove tenderlove committed Sep 18, 2013
Showing with 10 additions and 16 deletions.
  1. +10 −0 activerecord/CHANGELOG.md
  2. +0 −9 activerecord/lib/active_record/core.rb
  3. +0 −7 activerecord/test/cases/base_test.rb
View
10 activerecord/CHANGELOG.md
@@ -1,3 +1,13 @@
+* ActiveRecord::Base#<=> has been removed. Primary keys may not be in order,
+ or even be numbers, so sorting by id doesn't make sense. Please use `sort_by`
+ and specify the attribute you wish to sort with. For example, change:
+
+ Post.all.to_a.sort
+
+ to:
+
+ Post.all.to_a.sort_by(&:id)
+
* Fix: joins association, with defined in the scope block constraints by using several
where constraints and at least of them is not `Arel::Nodes::Equality`,
generates invalid SQL expression.
View
9 activerecord/lib/active_record/core.rb
@@ -308,15 +308,6 @@ def frozen?
@attributes.frozen?
end
- # Allows sort on objects
- def <=>(other_object)
- if other_object.is_a?(self.class)
- self.to_key <=> other_object.to_key
- else
- super
- end
- end
-
# Returns +true+ if the record is read only. Records loaded through joins with piggy-back
# attributes will be marked as read only since they cannot be saved.
def readonly?
View
7 activerecord/test/cases/base_test.rb
@@ -558,13 +558,6 @@ def test_hashing
assert_equal [ Topic.find(1) ], [ Topic.find(2).topic ] & [ Topic.find(1) ]
end
- def test_comparison
- topic_1 = Topic.create!
- topic_2 = Topic.create!
-
- assert_equal [topic_2, topic_1].sort, [topic_1, topic_2]
- end
-
def test_create_without_prepared_statement
topic = Topic.connection.unprepared_statement do
Topic.create(:title => 'foo')

0 comments on commit 6256734

Please sign in to comment.