Browse files

Fixed that HashWithIndifferentAccess stringified all keys including s…

…ymbols, ints, objects, and arrays #1162 [Nicholas Seckar]

git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1329 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
  • Loading branch information...
1 parent 7160ab1 commit 6375569484ce08f53dec8064146c2ca0c74affcd @dhh dhh committed May 19, 2005
View
2 activesupport/CHANGELOG
@@ -1,5 +1,7 @@
*SVN*
+* Fixed that HashWithIndifferentAccess stringified all keys including symbols, ints, objects, and arrays #1162 [Nicholas Seckar]
+
* Fixed Time#last_year to go back in time, not forward #1278 [fabien@odilat.com]
* Fixed the pluralization of analysis to analyses #1295 [seattle@rootimage.msu.edu]
View
2 activesupport/lib/active_support/core_ext/hash/indifferent_access.rb
@@ -3,7 +3,7 @@ class HashWithIndifferentAccess < Hash
def initialize(constructor = {})
if constructor.is_a?(Hash)
super()
- update(constructor.stringify_keys)
+ update(constructor)
else
super(constructor)
end
View
6 activesupport/test/core_ext/hash_ext_test.rb
@@ -110,4 +110,10 @@ def test_indifferent_subhashes
h = {:user => {:id => 5}}.with_indifferent_access
['user', :user].each {|user| [:id, 'id'].each {|id| assert_equal 5, h[user][id], "h[#{user.inspect}][#{id.inspect}] should be 5"}}
end
+
+ def test_assorted_keys_not_stringified
+ original = {Object.new => 2, 1 => 2, [] => true}
+ indiff = original.with_indifferent_access
+ assert(!indiff.keys.any? {|k| k.kind_of? String}, "A key was converted to a string!")
+ end
end

0 comments on commit 6375569

Please sign in to comment.