Skip to content

Commit 63d3809

Browse files
committed
Fix sprockets warnings
Fixes #2598
1 parent f25d65d commit 63d3809

File tree

3 files changed

+20
-7
lines changed

3 files changed

+20
-7
lines changed

actionpack/lib/sprockets/assets.rake

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -13,17 +13,20 @@ namespace :assets do
1313
# Ensure that action view is loaded and the appropriate sprockets hooks get executed
1414
ActionView::Base
1515

16-
assets = Rails.application.config.assets.precompile
1716
# Always perform caching so that asset_path appends the timestamps to file references.
1817
Rails.application.config.action_controller.perform_caching = true
18+
19+
config = Rails.application.config
20+
assets = config.assets.precompile.dup
21+
assets << {:to => File.join(Rails.public_path, config.assets.prefix)}
1922
Rails.application.assets.precompile(*assets)
2023
end
2124
end
2225

2326
desc "Remove compiled assets"
2427
task :clean => [:environment, 'tmp:cache:clear'] do
25-
assets = Rails.application.config.assets
26-
public_asset_path = Rails.public_path + assets.prefix
28+
config = Rails.application.config
29+
public_asset_path = File.join(Rails.public_path, config.assets.prefix)
2730
rm_rf public_asset_path, :secure => true
2831
end
2932
end

actionpack/lib/sprockets/helpers/rails_helper.rb

Lines changed: 12 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -112,11 +112,22 @@ def asset_for(source, ext)
112112
asset_environment[source]
113113
end
114114

115+
def digest_for(logical_path)
116+
if asset = asset_environment[logical_path]
117+
return asset.digest_path
118+
end
119+
120+
logical_path
121+
end
122+
115123
def rewrite_asset_path(source, dir)
116124
if source[0] == ?/
117125
source
118126
else
119-
asset_environment.path(source, performing_caching?, dir)
127+
source = digest_for(source) if performing_caching?
128+
source = File.join(dir, source)
129+
source = "/#{url}" unless source =~ /^\//
130+
source
120131
end
121132
end
122133

actionpack/lib/sprockets/railtie.rb

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -18,9 +18,8 @@ class Railtie < ::Rails::Railtie
1818
require 'sprockets'
1919

2020
app.assets = Sprockets::Environment.new(app.root.to_s) do |env|
21-
env.static_root = File.join(app.root.join('public'), config.assets.prefix)
22-
env.logger = ::Rails.logger
23-
env.version = ::Rails.env + "#{'-' + config.assets.version if config.assets.version.present?}"
21+
env.logger = ::Rails.logger
22+
env.version = ::Rails.env + "-#{config.assets.version}"
2423

2524
if config.assets.cache_store != false
2625
env.cache = ActiveSupport::Cache.lookup_store(config.assets.cache_store) || ::Rails.cache

0 commit comments

Comments
 (0)