Permalink
Browse files

making the comment more accurate

  • Loading branch information...
1 parent 59482f9 commit 65ec63f4ba011a1b46c6de83853ddc2da21bbc81 @tenderlove tenderlove committed Jul 3, 2013
Showing with 5 additions and 2 deletions.
  1. +5 −2 activerecord/lib/active_record/attribute_methods/read.rb
@@ -33,8 +33,11 @@ def cache_attribute?(attr_name)
protected
# We want to generate the methods via module_eval rather than
- # define_method, because define_method is slower on dispatch and
- # uses more memory (because it creates a closure).
+ # define_method, because define_method is slower on dispatch.
+ # Evaluating many similar methods may use more memory as the instruction
+ # sequences are duplicated and cached (in MRI). define_method may
+ # be slower on dispatch, but if you're careful about the closure
+ # created, then define_method will consume much less memory.
#
# But sometimes the database might return columns with
# characters that are not allowed in normal method names (like

0 comments on commit 65ec63f

Please sign in to comment.