Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP
Browse files

add code coverage testing scripts, remove dead code

detected by said scripts


git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@708 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
  • Loading branch information...
commit 6a7fc51c6675786f4791c45edc1fac42ea6e3df9 1 parent acb3d2c
@bitserf bitserf authored
View
2  actionwebservice/ChangeLog
@@ -1,6 +1,6 @@
UNRELEASED
- * lib/action_service/dispatcher*: replaces "router" fragments with
+ * lib/action_service/dispatcher*: replace "router" fragments with
one file for Action Controllers, moves dispatching work out of
the container
* lib/*,test/*,examples/*: rename project to
View
31 actionwebservice/TODO
@@ -1,34 +1,3 @@
-= 0.4.0 Tasks
- - add ActiveRecord-like logging that includes timing information
-
-= Post-0.4.0 Tasks
- - support namespaced custom types in WSDL in a way that interoperates
- with .NET (.NET croaks on '::' currently). perhaps a transform
- that maps Ruby::Class to Ruby.Class and back.
-
- - relax type-checking for XML-RPC, and perform casts between base types if there
- are mismatches (i.e. String received when Integer expected, or vice-versa)
-
- - support XML-RPC's "handler." method namespacing. perhaps something like:
-
- class BloggingServices < ActionWebService::LayeredService
- def initialize(request)
- @request = controller.request
- end
-
- web_service :mt {MTService.new(@request)}
- web_service :blogger {BloggerService.new(@request)}
- web_service :metaWeblog {MetaWeblogService.new(@request)}
- end
-
- class ApiController < ApplicationController
- web_service_dispatching_mode :delegated
- web_service :xmlrpc { BloggingServices.new(@request) }
- end
-
- - verify that cookie support works, and add cookie-authenticated
- service examples. test with .NET.
-
= Low priority tasks
- add better type mapping tests for XML-RPC
- add tests for ActiveRecord support (with mock objects?)
View
8 actionwebservice/lib/action_web_service/dispatcher/abstract.rb
@@ -75,10 +75,6 @@ def delegated_invoke(request)
return_value
end
- def fallback_invoke(dispatch_request)
- raise NotImplementedError
- end
-
def prepare_dispatch_request(protocol_request)
api = method_name = web_service_name = web_service = params = nil
public_method_name = protocol_request.public_method_name
@@ -122,15 +118,11 @@ def prepare_exception_response(protocol_request, exception)
when :direct
if web_service_exception_reporting
return protocol_request.protocol.marshal_exception(exception)
- else
- raise exception
end
when :delegated
web_service = web_service_object(protocol_request.web_service_name)
if web_service && web_service.class.web_service_exception_reporting
return protocol_request.protocol.marshal_exception(exception)
- else
- raise exception
end
end
else
View
2  actionwebservice/lib/action_web_service/dispatcher/action_controller_dispatcher.rb
@@ -7,8 +7,6 @@ def self.append_features(base) # :nodoc:
class << self
alias_method :inherited_without_action_controller, :inherited
end
- end
- base.class_eval do
alias_method :before_direct_invoke_without_action_controller, :before_direct_invoke
alias_method :after_direct_invoke_without_action_controller, :after_direct_invoke
end
View
3  actionwebservice/test/gencov
@@ -0,0 +1,3 @@
+#!/bin/sh
+
+rcov -x '.*_test\.rb,rubygems,abstract_,/run' ./run
View
5 actionwebservice/test/run
@@ -0,0 +1,5 @@
+#!/usr/bin/env ruby
+
+Dir[File.join(File.dirname(__FILE__), '*_test.rb')].each do |f|
+ require f
+end
Please sign in to comment.
Something went wrong with that request. Please try again.