Permalink
Show file tree
Hide file tree
27 comments
on commit
sign in to comment.
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Showing
30 changed files
with
7 additions
and
1,020 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -6,7 +6,6 @@ module ActionController | ||
|
|
||
| autoload :Base | ||
| autoload :Caching | ||
| autoload :HTTP | ||
| autoload :Metal | ||
| autoload :Middleware | ||
|
|
||
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
6db930cThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Out of curiosity, why is this being removed?
6db930cThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, this didn't stick around for long... +1 on the what happened?
6db930cThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interesting question. ~4 hours ago @josevalim twittered that
rails new --httplanded in rails master and now he's removing it already. Care to share the reasons behind that?6db930cThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 indeed: why is this removed?
6db930cThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wow, some rationale behind this would be nice
6db930cThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
6db930cThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
6db930cThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing reason yet :P
6db930cThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
6db930cThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Guys let me catch up with some stuff and then I will try to explain the reasons
6db930cThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
6db930cThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
6db930cThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1.2
6db930cThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
6db930cThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you were interested in this feature, you should definitely check out Lightrail!
https://github.com/lightness/lightrail
6db930cThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is really disappointing. I was really looking forward to this feature.
6db930cThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be nice if the explanations were included in the commit messages. Just writing "Remove --http." is a bit rude.
6db930cThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When I heard this feature would be in, I was excited, and thought that I may use rails like that. Then it gets taken out. I am disappoint.
6db930cThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My first opinion is that I'm very happy about this. Let's start cutting things OUT of rails and start moving them into gems that you can bring it. Instead of adding more features into rails, just improve rails so that these features can be added on by gems.
6db930cThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1💀 API ALL THE THINGS
6db930cThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I liked this feature, how to put this feature as a gem if the idea was generate the rails app to use as api server.
6db930cThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In case you missed my earlier remark, Lightrail is this feature (or rather, an earlier version of it) in a separate gem/project which can evolve independently of Rails. Lightrail is a custom Rails 3 stack for JSON APIs, principally authored by @josevalim:
https://github.com/lightness/lightrail
Still untested (working on it!) and early-stage, but please give it a look!
6db930cThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We're absolutely moving in this direction. This is not one single feature; it's a package of ideas and philosophy wrapped up in a couple config options.
Building up a purpose-built API stack (like we do in our own apps) is the driving force, but that's the benefit, not the feature. So calling it "API" or "HTTP" puts the cart before the horse.
Expect to see these underlying ideas and motivations find their way in to Rails in small, bite-sized pieces: bare applications (bootable engines, you add the middleware), thin controllers (just the http basics, you add serialization, streaming, whatever), and the ability to leave out views/templates entirely.
TL;DR it's coming, but from the ground up instead of from bloat down.
6db930cThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jeremy good to hear. I'm excited about this change. Anything us outsiders can do to help?
6db930cThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jherdman @jeremy It makes me sad that an OSS project has outsiders. Besides the point.
6db930cThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Released as a plugin, read more here http://blog.wyeworks.com/2012/4/20/rails-for-api-applications-rails-api-released
6db930cThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Muchas gracias @spastorino