Skip to content
Permalink
Browse files

Remove --http.

  • Loading branch information
josevalim committed Mar 14, 2012
1 parent 1efeb07 commit 6db930cb5bbff9ad824590b5844e04768de240b1
Showing with 7 additions and 1,020 deletions.
  1. +0 −2 actionpack/CHANGELOG.md
  2. +0 −1 actionpack/lib/action_controller.rb
  3. +0 −134 actionpack/lib/action_controller/http.rb
  4. +0 −4 actionpack/test/abstract_unit.rb
  5. +0 −19 actionpack/test/controller/http/action_methods_test.rb
  6. +0 −55 actionpack/test/controller/http/conditional_get_test.rb
  7. +0 −27 actionpack/test/controller/http/data_streaming_test.rb
  8. +0 −20 actionpack/test/controller/http/force_ssl_test.rb
  9. +0 −19 actionpack/test/controller/http/redirect_to_test.rb
  10. +0 −37 actionpack/test/controller/http/renderers_test.rb
  11. +0 −20 actionpack/test/controller/http/url_for_test.rb
  12. +0 −271 railties/guides/source/api_app.textile
  13. +0 −20 railties/lib/rails/configuration.rb
  14. +1 −22 railties/lib/rails/generators.rb
  15. +0 −8 railties/lib/rails/generators/rails/app/app_generator.rb
  16. +3 −3 railties/lib/rails/generators/rails/app/templates/app/controllers/application_controller.rb.tt
  17. +0 −9 railties/lib/rails/generators/rails/app/templates/config/application.rb
  18. +0 −1 railties/lib/rails/generators/rails/resource/resource_generator.rb
  19. +1 −2 railties/lib/rails/generators/rails/scaffold_controller/scaffold_controller_generator.rb
  20. +0 −60 railties/lib/rails/generators/rails/scaffold_controller/templates/http_controller.rb
  21. +2 −4 railties/lib/rails/generators/test_unit/scaffold/scaffold_generator.rb
  22. +0 −50 railties/lib/rails/generators/test_unit/scaffold/templates/http_functional_test.rb
  23. +0 −28 railties/test/application/generators_test.rb
  24. +0 −27 railties/test/application/initializers/frameworks_test.rb
  25. +0 −30 railties/test/application/middleware_test.rb
  26. +0 −20 railties/test/application/rake_test.rb
  27. +0 −33 railties/test/generators/app_generator_test.rb
  28. +0 −6 railties/test/generators/resource_generator_test.rb
  29. +0 −37 railties/test/generators/scaffold_controller_generator_test.rb
  30. +0 −51 railties/test/generators_test.rb
@@ -1,7 +1,5 @@
## Rails 4.0.0 (unreleased) ##

* Support API apps http://edgeguides.rubyonrails.org/api_app.html *Santiago Pastorino and Carlos Antonio da Silva*

* Add `include_hidden` option to select tag. With `:include_hidden => false` select with `multiple` attribute doesn't generate hidden input with blank value. *Vasiliy Ermolovich*

* Removed default `size` option from the `text_field`, `search_field`, `telephone_field`, `url_field`, `email_field` helpers. *Philip Arndt*
@@ -6,7 +6,6 @@ module ActionController

autoload :Base
autoload :Caching
autoload :HTTP
autoload :Metal
autoload :Middleware

This file was deleted.

@@ -293,10 +293,6 @@ def self.test_routes(&block)
end
end

class HTTP
include SharedTestRoutes.url_helpers
end

class TestCase
include ActionDispatch::TestProcess

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

27 comments on commit 6db930c

@jashkenas

This comment has been minimized.

Copy link

@jashkenas jashkenas replied Mar 14, 2012

Out of curiosity, why is this being removed?

@derekprior

This comment has been minimized.

Copy link
Contributor

@derekprior derekprior replied Mar 14, 2012

Well, this didn't stick around for long... +1 on the what happened?

@nicolai86

This comment has been minimized.

Copy link

@nicolai86 nicolai86 replied Mar 14, 2012

Interesting question. ~4 hours ago @josevalim twittered that rails new --http landed in rails master and now he's removing it already. Care to share the reasons behind that?

@nathanvda

This comment has been minimized.

Copy link

@nathanvda nathanvda replied Mar 14, 2012

+1 indeed: why is this removed?

@masterkain

This comment has been minimized.

Copy link
Contributor

@masterkain masterkain replied Mar 14, 2012

wow, some rationale behind this would be nice

@carlosramireziii

This comment has been minimized.

Copy link
Contributor

@carlosramireziii carlosramireziii replied Mar 15, 2012

+1

@jherdman

This comment has been minimized.

Copy link

@jherdman jherdman replied Mar 15, 2012

+1

@sobrinho

This comment has been minimized.

Copy link
Contributor

@sobrinho sobrinho replied Mar 15, 2012

Missing reason yet :P

@ngelx

This comment has been minimized.

Copy link

@ngelx ngelx replied Mar 15, 2012

+1

@spastorino

This comment has been minimized.

Copy link
Member

@spastorino spastorino replied Mar 15, 2012

Guys let me catch up with some stuff and then I will try to explain the reasons

@deepj

This comment has been minimized.

Copy link
Contributor

@deepj deepj replied Mar 15, 2012

+1

@mcastilho

This comment has been minimized.

Copy link

@mcastilho mcastilho replied Mar 16, 2012

+1

@raholland79

This comment has been minimized.

Copy link

@raholland79 raholland79 replied Mar 16, 2012

+1.2

@jeremy

This comment has been minimized.

Copy link
Member

@jeremy jeremy replied Mar 16, 2012

I have a doubt

@tarcieri

This comment has been minimized.

Copy link
Contributor

@tarcieri tarcieri replied Mar 16, 2012

If you were interested in this feature, you should definitely check out Lightrail!

https://github.com/lightness/lightrail

@steveklabnik

This comment has been minimized.

Copy link
Member

@steveklabnik steveklabnik replied Mar 16, 2012

This is really disappointing. I was really looking forward to this feature.

@dlitz

This comment has been minimized.

Copy link

@dlitz dlitz replied Mar 16, 2012

It would be nice if the explanations were included in the commit messages. Just writing "Remove --http." is a bit rude.

@isaacsanders

This comment has been minimized.

Copy link
Contributor

@isaacsanders isaacsanders replied Mar 16, 2012

When I heard this feature would be in, I was excited, and thought that I may use rails like that. Then it gets taken out. I am disappoint.

@coreyhaines

This comment has been minimized.

Copy link
Contributor

@coreyhaines coreyhaines replied Mar 16, 2012

My first opinion is that I'm very happy about this. Let's start cutting things OUT of rails and start moving them into gems that you can bring it. Instead of adding more features into rails, just improve rails so that these features can be added on by gems.

@shapeshed

This comment has been minimized.

Copy link

@shapeshed shapeshed replied Mar 16, 2012

+1 💀 API ALL THE THINGS

@marceloandrader

This comment has been minimized.

Copy link

@marceloandrader marceloandrader replied Mar 16, 2012

I liked this feature, how to put this feature as a gem if the idea was generate the rails app to use as api server.

@tarcieri

This comment has been minimized.

Copy link
Contributor

@tarcieri tarcieri replied Mar 16, 2012

In case you missed my earlier remark, Lightrail is this feature (or rather, an earlier version of it) in a separate gem/project which can evolve independently of Rails. Lightrail is a custom Rails 3 stack for JSON APIs, principally authored by @josevalim:

https://github.com/lightness/lightrail

Still untested (working on it!) and early-stage, but please give it a look!

@jeremy

This comment has been minimized.

Copy link
Member

@jeremy jeremy replied Mar 16, 2012

We're absolutely moving in this direction. This is not one single feature; it's a package of ideas and philosophy wrapped up in a couple config options.

Building up a purpose-built API stack (like we do in our own apps) is the driving force, but that's the benefit, not the feature. So calling it "API" or "HTTP" puts the cart before the horse.

Expect to see these underlying ideas and motivations find their way in to Rails in small, bite-sized pieces: bare applications (bootable engines, you add the middleware), thin controllers (just the http basics, you add serialization, streaming, whatever), and the ability to leave out views/templates entirely.

TL;DR it's coming, but from the ground up instead of from bloat down.

@jherdman

This comment has been minimized.

Copy link

@jherdman jherdman replied Mar 16, 2012

@jeremy good to hear. I'm excited about this change. Anything us outsiders can do to help?

@isaacsanders

This comment has been minimized.

Copy link
Contributor

@isaacsanders isaacsanders replied Mar 16, 2012

@jherdman @jeremy It makes me sad that an OSS project has outsiders. Besides the point.

@spastorino

This comment has been minimized.

Copy link
Member

@spastorino spastorino replied Apr 20, 2012

@fedesoria

This comment has been minimized.

Copy link
Contributor

@fedesoria fedesoria replied Apr 21, 2012

Muchas gracias @spastorino

Please sign in to comment.
You can’t perform that action at this time.