Skip to content
Permalink
Browse files
Remove --http.
  • Loading branch information
josevalim committed Mar 14, 2012
1 parent 1efeb07 commit 6db930cb5bbff9ad824590b5844e04768de240b1
Show file tree
Hide file tree
Showing 30 changed files with 7 additions and 1,020 deletions.
@@ -1,7 +1,5 @@
## Rails 4.0.0 (unreleased) ##

* Support API apps http://edgeguides.rubyonrails.org/api_app.html *Santiago Pastorino and Carlos Antonio da Silva*

* Add `include_hidden` option to select tag. With `:include_hidden => false` select with `multiple` attribute doesn't generate hidden input with blank value. *Vasiliy Ermolovich*

* Removed default `size` option from the `text_field`, `search_field`, `telephone_field`, `url_field`, `email_field` helpers. *Philip Arndt*
@@ -6,7 +6,6 @@ module ActionController

autoload :Base
autoload :Caching
autoload :HTTP
autoload :Metal
autoload :Middleware

This file was deleted.

@@ -293,10 +293,6 @@ def self.test_routes(&block)
end
end

class HTTP
include SharedTestRoutes.url_helpers
end

class TestCase
include ActionDispatch::TestProcess

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

27 comments on commit 6db930c

@jashkenas
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Out of curiosity, why is this being removed?

@derekprior
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, this didn't stick around for long... +1 on the what happened?

@nicolai86
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting question. ~4 hours ago @josevalim twittered that rails new --http landed in rails master and now he's removing it already. Care to share the reasons behind that?

@nathanvda
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 indeed: why is this removed?

@masterkain
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wow, some rationale behind this would be nice

@carlosramireziii
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@jherdman
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@sobrinho
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing reason yet :P

@ngelx
Copy link

@ngelx ngelx commented on 6db930c Mar 15, 2012

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@spastorino
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Guys let me catch up with some stuff and then I will try to explain the reasons

@deepj
Copy link
Contributor

@deepj deepj commented on 6db930c Mar 15, 2012

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@mcastilho
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@raholland79
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1.2

@jeremy
Copy link
Member

@jeremy jeremy commented on 6db930c Mar 16, 2012

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a doubt

@tarcieri
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you were interested in this feature, you should definitely check out Lightrail!

https://github.com/lightness/lightrail

@steveklabnik
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is really disappointing. I was really looking forward to this feature.

@dlitz
Copy link

@dlitz dlitz commented on 6db930c Mar 16, 2012

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice if the explanations were included in the commit messages. Just writing "Remove --http." is a bit rude.

@isaacsanders
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I heard this feature would be in, I was excited, and thought that I may use rails like that. Then it gets taken out. I am disappoint.

@coreyhaines
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My first opinion is that I'm very happy about this. Let's start cutting things OUT of rails and start moving them into gems that you can bring it. Instead of adding more features into rails, just improve rails so that these features can be added on by gems.

@shapeshed
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 💀 API ALL THE THINGS

@marceloandrader
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I liked this feature, how to put this feature as a gem if the idea was generate the rails app to use as api server.

@tarcieri
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In case you missed my earlier remark, Lightrail is this feature (or rather, an earlier version of it) in a separate gem/project which can evolve independently of Rails. Lightrail is a custom Rails 3 stack for JSON APIs, principally authored by @josevalim:

https://github.com/lightness/lightrail

Still untested (working on it!) and early-stage, but please give it a look!

@jeremy
Copy link
Member

@jeremy jeremy commented on 6db930c Mar 16, 2012

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're absolutely moving in this direction. This is not one single feature; it's a package of ideas and philosophy wrapped up in a couple config options.

Building up a purpose-built API stack (like we do in our own apps) is the driving force, but that's the benefit, not the feature. So calling it "API" or "HTTP" puts the cart before the horse.

Expect to see these underlying ideas and motivations find their way in to Rails in small, bite-sized pieces: bare applications (bootable engines, you add the middleware), thin controllers (just the http basics, you add serialization, streaming, whatever), and the ability to leave out views/templates entirely.

TL;DR it's coming, but from the ground up instead of from bloat down.

@jherdman
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jeremy good to hear. I'm excited about this change. Anything us outsiders can do to help?

@isaacsanders
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jherdman @jeremy It makes me sad that an OSS project has outsiders. Besides the point.

@spastorino
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fedesoria
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Muchas gracias @spastorino

Please sign in to comment.