Permalink
Browse files

Remove deprecated `ActiveRecord::Base.disable_implicit_join_reference…

…s=`.
  • Loading branch information...
arunagw committed Jul 4, 2013
1 parent 1bf5fc2 commit 6dd7f7c04edeeb97f5dfa8cdcfdcf13eb503f277
Showing with 4 additions and 11 deletions.
  1. +4 −0 activerecord/CHANGELOG.md
  2. +0 −5 activerecord/lib/active_record/core.rb
  3. +0 −6 activerecord/test/cases/relations_test.rb
@@ -1,3 +1,7 @@
+* Remove deprecated `ActiveRecord::Base.disable_implicit_join_references=`.
+
+ *Arun Agrawal*
+
* Remove deprecated nil-passing to the following `SchemaCache` methods:
`primary_keys`, `tables`, `columns` and `columns_hash`.
@@ -69,11 +69,6 @@ module Core
mattr_accessor :timestamped_migrations, instance_writer: false
self.timestamped_migrations = true
- def self.disable_implicit_join_references=(value)
- ActiveSupport::Deprecation.warn("Implicit join references were removed with Rails 4.1." \
- "Make sure to remove this configuration because it does nothing.")
- end
-
class_attribute :default_connection_handler, instance_writer: false
def self.connection_handler
@@ -1216,12 +1216,6 @@ def test_primary_key
assert_equal "id", Post.all.primary_key
end
- def test_disable_implicit_join_references_is_deprecated
- assert_deprecated do
- ActiveRecord::Base.disable_implicit_join_references = true
- end
- end
-
def test_ordering_with_extra_spaces
assert_equal authors(:david), Author.order('id DESC , name DESC').last
end

2 comments on commit 6dd7f7c

@senny

This comment has been minimized.

Show comment Hide comment
@senny

senny Jul 5, 2013

Member

I had to revert this change: b54ef7e

This accessor was introduced with Rails 4 and I deprecated it on master. We need to wait for 4.1 before we can remove it.

Member

senny replied Jul 5, 2013

I had to revert this change: b54ef7e

This accessor was introduced with Rails 4 and I deprecated it on master. We need to wait for 4.1 before we can remove it.

@arunagw

This comment has been minimized.

Show comment Hide comment
@arunagw

arunagw Jul 5, 2013

Member

thanks @senny 💙

Sorry about this.

Member

arunagw replied Jul 5, 2013

thanks @senny 💙

Sorry about this.

Please sign in to comment.