Skip to content
Browse files

Add a test case of nested empty array values in conditions

  Post.where(id: [[]]).to_a

Used to fail with a SQL syntax error (until 4.1):

  SELECT ... WHERE id in ();

It now properly generate:

  SELECT ... WHERE 1=0;
  • Loading branch information...
1 parent d202706 commit 6fdf5167b7a49a4cdd9d47570ddcebcbbf808e99 @byroot byroot committed Aug 17, 2014
Showing with 4 additions and 0 deletions.
  1. +4 −0 activerecord/test/cases/relation/where_test.rb
View
4 activerecord/test/cases/relation/where_test.rb
@@ -180,6 +180,10 @@ def test_where_with_table_name_and_empty_array
assert_equal 0, Post.where(:id => []).count
end
+ def test_where_with_table_name_and_nested_empty_array
+ assert_equal [], Post.where(:id => [[]]).to_a
+ end
+
def test_where_with_empty_hash_and_no_foreign_key
assert_equal 0, Edge.where(:sink => {}).count
end

0 comments on commit 6fdf516

Please sign in to comment.
Something went wrong with that request. Please try again.