Permalink
Browse files

users_dont_suck_but_only_we_suck_and_only_our_tests_are_order_dependent!

Calling ActiveSupport::TestCase.i_suck_and_my_tests_are_order_dependent! in AS::TestCase makes
everyone's tests order dependent, which should never be done by the framework.
  • Loading branch information...
amatsuda committed Aug 12, 2014
1 parent c27883c commit 6ffb29d24e05abbd9ffe3ea974140d6c70221807
@@ -51,3 +51,8 @@ def jruby_skip(message = '')
end
require 'mocha/setup' # FIXME: stop using mocha
+
+# FIXME: we have tests that depend on run order, we should fix that and
+# remove this method call.
+require 'active_support/test_case'
+ActiveSupport::TestCase.i_suck_and_my_tests_are_order_dependent!
@@ -497,3 +497,8 @@ def shutdown
# Use N processes (N defaults to 4)
Minitest.parallel_executor = ForkingExecutor.new(PROCESS_COUNT)
end
+
+# FIXME: we have tests that depend on run order, we should fix that and
+# remove this method call.
+require 'active_support/test_case'
+ActiveSupport::TestCase.i_suck_and_my_tests_are_order_dependent!
@@ -340,3 +340,8 @@ def jruby_skip(message = '')
end
require 'mocha/setup' # FIXME: stop using mocha
+
+# FIXME: we have tests that depend on run order, we should fix that and
+# remove this method call.
+require 'active_support/test_case'
+ActiveSupport::TestCase.i_suck_and_my_tests_are_order_dependent!
@@ -13,3 +13,8 @@
require 'active_support/testing/autorun'
require 'mocha/setup' # FIXME: stop using mocha
+
+# FIXME: we have tests that depend on run order, we should fix that and
+# remove this method call.
+require 'active_support/test_case'
+ActiveSupport::TestCase.i_suck_and_my_tests_are_order_dependent!
@@ -201,3 +201,8 @@ def in_time_zone(zone)
end
require 'mocha/setup' # FIXME: stop using mocha
+
+# FIXME: we have tests that depend on run order, we should fix that and
+# remove this method call.
+require 'active_support/test_case'
+ActiveSupport::TestCase.i_suck_and_my_tests_are_order_dependent!
@@ -22,10 +22,6 @@ def self.for_tag(tag)
yield if $tags[tag]
end
- # FIXME: we have tests that depend on run order, we should fix that and
- # remove this method call.
- self.i_suck_and_my_tests_are_order_dependent!
-
include ActiveSupport::Testing::TaggedLogging
include ActiveSupport::Testing::SetupAndTeardown
include ActiveSupport::Testing::Assertions
@@ -38,3 +38,8 @@ def jruby_skip(message = '')
end
require 'mocha/setup' # FIXME: stop using mocha
+
+# FIXME: we have tests that depend on run order, we should fix that and
+# remove this method call.
+require 'active_support/test_case'
+ActiveSupport::TestCase.i_suck_and_my_tests_are_order_dependent!
@@ -28,6 +28,10 @@ def jruby_skip(message = '')
end
class ActiveSupport::TestCase
+ # FIXME: we have tests that depend on run order, we should fix that and
+ # remove this method call.
+ self.i_suck_and_my_tests_are_order_dependent!
+
private
unless defined?(:capture)

6 comments on commit 6ffb29d

@sikachu

This comment has been minimized.

Show comment
Hide comment
@sikachu

sikachu Aug 12, 2014

Member

👍

I really hope we can remove this stupid flag soon.

Member

sikachu replied Aug 12, 2014

👍

I really hope we can remove this stupid flag soon.

@rafaelfranca

This comment has been minimized.

Show comment
Hide comment
@rafaelfranca

rafaelfranca Aug 12, 2014

Member

👍

BTW, we need to add this to CHANGELOG entry and release notes. or people application can break because they are really order dependent and people will not understand why.

Member

rafaelfranca replied Aug 12, 2014

👍

BTW, we need to add this to CHANGELOG entry and release notes. or people application can break because they are really order dependent and people will not understand why.

@rafaelfranca

This comment has been minimized.

Show comment
Hide comment
@rafaelfranca

rafaelfranca Aug 12, 2014

Member

Just saw it was added. Thanks @amatsuda

Member

rafaelfranca replied Aug 12, 2014

Just saw it was added. Thanks @amatsuda

@zzak

This comment has been minimized.

Show comment
Hide comment
@zzak

zzak Aug 20, 2014

Member

Can we bump minitest yet?

cc @amatsuda @rafaelfranca

Member

zzak replied Aug 20, 2014

Can we bump minitest yet?

cc @amatsuda @rafaelfranca

@rafaelfranca

This comment has been minimized.

Show comment
Hide comment
@rafaelfranca

rafaelfranca Aug 21, 2014

Member

lets wait the stable branching

Member

rafaelfranca replied Aug 21, 2014

lets wait the stable branching

@zenspider

This comment has been minimized.

Show comment
Hide comment
@zenspider

zenspider Sep 8, 2014

Contributor

I've been working on a tool called minitest-bisect that helps hunt down order dependency issues. Thus far using it and previous incarnations of it, I've hunted down and killed off 3-4 rails test problems. It's driven out 3-4 in devise today alone. It probably needs some more polish and doco, but I think it's the answer to this stuff.

Contributor

zenspider replied Sep 8, 2014

I've been working on a tool called minitest-bisect that helps hunt down order dependency issues. Thus far using it and previous incarnations of it, I've hunted down and killed off 3-4 rails test problems. It's driven out 3-4 in devise today alone. It probably needs some more polish and doco, but I think it's the answer to this stuff.

Please sign in to comment.