Skip to content
Permalink
Browse files

rename _snowman to _e

  • Loading branch information...
wycats committed Aug 9, 2010
1 parent 6767946 commit 7171161124a2852ee7b40c5c632ba8e092c97409
@@ -538,7 +538,7 @@ def html_options_for_form(url_for_options, options, *parameters_for_url)

def extra_tags_for_form(html_options)
snowman_tag = tag(:input, :type => "hidden",
:name => "_snowman", :value => "☃".html_safe)
:name => "_e", :value => "☃".html_safe)

method = html_options.delete("method").to_s

@@ -1513,7 +1513,7 @@ def test_form_for_with_labelled_builder

def snowman(method = nil)
txt = %{<div style="margin:0;padding:0;display:inline">}
txt << %{<input name="_snowman" type="hidden" value="&#9731;" />}
txt << %{<input name="_e" type="hidden" value="&#9731;" />}
txt << %{<input name="_method" type="hidden" value="#{method}" />} if method
txt << %{</div>}
end
@@ -12,7 +12,7 @@ def snowman(options = {})
method = options[:method]

txt = %{<div style="margin:0;padding:0;display:inline">}
txt << %{<input name="_snowman" type="hidden" value="&#9731;" />}
txt << %{<input name="_e" type="hidden" value="&#9731;" />}
txt << %{<input name="_method" type="hidden" value="#{method}" />} if method
txt << %{</div>}
end

15 comments on commit 7171161

@reu

This comment has been minimized.

Copy link
Contributor

reu replied Aug 9, 2010

Oh noes! This is a sad day for rails =/

@sikachu

This comment has been minimized.

Copy link
Member

sikachu replied Aug 10, 2010

I request a revert of this commit :(

@jm3

This comment has been minimized.

Copy link

jm3 replied Aug 10, 2010

melting

@kirel

This comment has been minimized.

Copy link

kirel replied Aug 10, 2010

Nooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooo!

@adrianpacala

This comment has been minimized.

Copy link
Contributor

adrianpacala replied Aug 10, 2010

Please STFU already - it's getting annoying. Thank you.

@paukul

This comment has been minimized.

Copy link
Contributor

paukul replied Aug 10, 2010

STFU? Nooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooo!

@stygeo

This comment has been minimized.

Copy link

stygeo replied Aug 10, 2010

Noooooooooo, not the snowman! :( I also request a revert of this commit.

@davout

This comment has been minimized.

Copy link
Contributor

davout replied Aug 10, 2010

+1 for reverting this commit, "rails snowman" will be an easier google query than "rails e" for the lost souls wondering what the hell their app is hiding in their request parameters

@paukul

This comment has been minimized.

Copy link
Contributor

paukul replied Aug 10, 2010

what about using a name that describes the purpose?
if _snowman is not considered appropriate then what about _ie_encoding_hint or something similar?
that would also help "the lost soul" figuring out what the f* is going on

@davout

This comment has been minimized.

Copy link
Contributor

davout replied Aug 10, 2010

leaving "_e" as a request parameter would make me feel like i regressed back to dotnet

@ncr

This comment has been minimized.

Copy link
Contributor

ncr replied Aug 10, 2010

leave snowman alone! but seriously _ie_encoding_hint would be better than enigmatic _e

@samgranieri

This comment has been minimized.

Copy link
Contributor

samgranieri replied Aug 10, 2010

What's the deal with the snowman?

@qoobaa

This comment has been minimized.

Copy link
Contributor

qoobaa replied Aug 10, 2010

@ncr: what a waste! _e param saves 6 bytes of memory... in every single form in the app!

@rubys

This comment has been minimized.

Copy link
Contributor

rubys replied Aug 10, 2010

Tossing this out there as something that might restore a bit of fun, while remaining functional, and being eminently searchable...


          snowman_tag = tag(:input, :type => "hidden",
                            :name => "8-&#x025f;&#x0287;n".html_safe,
                            :value => "&#x0183;&#x0131;po&#x0254;u&#x01dd;".html_safe)

http://tinyurl.com/2czkp49

@locriani

This comment has been minimized.

Copy link

locriani replied Aug 10, 2010

I want my snowman! If anything, though, _ie_encoding_hint, not _e.

Please sign in to comment.
You can’t perform that action at this time.