Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP
Browse files

rename _snowman to _e

  • Loading branch information...
commit 7171161124a2852ee7b40c5c632ba8e092c97409 1 parent 6767946
Yehuda Katz wycats authored
2  actionpack/lib/action_view/helpers/form_tag_helper.rb
View
@@ -538,7 +538,7 @@ def html_options_for_form(url_for_options, options, *parameters_for_url)
def extra_tags_for_form(html_options)
snowman_tag = tag(:input, :type => "hidden",
- :name => "_snowman", :value => "☃".html_safe)
+ :name => "_e", :value => "☃".html_safe)
method = html_options.delete("method").to_s
2  actionpack/test/template/form_helper_test.rb
View
@@ -1513,7 +1513,7 @@ def test_form_for_with_labelled_builder
def snowman(method = nil)
txt = %{<div style="margin:0;padding:0;display:inline">}
- txt << %{<input name="_snowman" type="hidden" value="&#9731;" />}
+ txt << %{<input name="_e" type="hidden" value="&#9731;" />}
txt << %{<input name="_method" type="hidden" value="#{method}" />} if method
txt << %{</div>}
end
2  actionpack/test/template/form_tag_helper_test.rb
View
@@ -12,7 +12,7 @@ def snowman(options = {})
method = options[:method]
txt = %{<div style="margin:0;padding:0;display:inline">}
- txt << %{<input name="_snowman" type="hidden" value="&#9731;" />}
+ txt << %{<input name="_e" type="hidden" value="&#9731;" />}
txt << %{<input name="_method" type="hidden" value="#{method}" />} if method
txt << %{</div>}
end

15 comments on commit 7171161

Rodrigo Navarro

Oh noes! This is a sad day for rails =/

Prem Sichanugrist
Collaborator

I request a revert of this commit :(

John Manoogian III

#melting

Daniel Kirsch

Nooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooo!

Adrian Pacała

Please STFU already - it's getting annoying. Thank you.

Pascal Friederich

STFU? Nooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooo!

Jeffrey Wilcke

Noooooooooo, not the snowman! :( I also request a revert of this commit.

David FRANCOIS

+1 for reverting this commit, "rails snowman" will be an easier google query than "rails e" for the lost souls wondering what the hell their app is hiding in their request parameters

Pascal Friederich

what about using a name that describes the purpose?
if _snowman is not considered appropriate then what about _ie_encoding_hint or something similar?
that would also help "the lost soul" figuring out what the f* is going on

David FRANCOIS

leaving "_e" as a request parameter would make me feel like i regressed back to dotnet

Jacek Becela

leave snowman alone! but seriously _ie_encoding_hint would be better than enigmatic _e

Sam Granieri

What's the deal with the snowman?

Kuba Kuźma

@ncr: what a waste! _e param saves 6 bytes of memory... in every single form in the app!

Sam Ruby

Tossing this out there as something that might restore a bit of fun, while remaining functional, and being eminently searchable...


          snowman_tag = tag(:input, :type => "hidden",
                            :name => "8-&#x025f;&#x0287;n".html_safe,
                            :value => "&#x0183;&#x0131;po&#x0254;u&#x01dd;".html_safe)

http://tinyurl.com/2czkp49

Zach Gardner

I want my snowman! If anything, though, _ie_encoding_hint, not _e.

Please sign in to comment.
Something went wrong with that request. Please try again.