Permalink
Browse files

When empty options passed to having clause having_values was [nil] bu…

…t should be empty.
  • Loading branch information...
konukhov committed Apr 23, 2013
1 parent a56b150 commit 746a9992f0a842ded7a15cc5ce0afd0fa00f2ada
@@ -551,7 +551,6 @@ def where!(opts = :chain, *rest) # :nodoc:
# Order.having('SUM(price) > 30').group('user_id')
def having(opts, *rest)
opts.blank? ? self : spawn.having!(opts, *rest)
- spawn.having!(opts, *rest)
end
def having!(opts, *rest) # :nodoc:
@@ -1299,6 +1299,14 @@ def test_distinct
assert_equal ['Foo', 'Foo'], query.uniq(true).uniq(false).map(&:name)
end
+ def test_doesnt_add_having_values_if_options_are_blank
+ scope = Post.having('')
+ assert_equal [], scope.having_values
+
+ scope = Post.having([])
+ assert_equal [], scope.having_values
+ end
+
def test_references_triggers_eager_loading
scope = Post.includes(:comments)
assert !scope.eager_loading?

0 comments on commit 746a999

Please sign in to comment.