Skip to content
Browse files

Merge pull request #2018 from bhus/render_partial_invalid_check

Render partial invalid check
  • Loading branch information...
2 parents ac97e25 + 2668dce commit 7669c33c745b3e35e5c080bdeea3a991de3e8183 @spastorino spastorino committed Jul 17, 2011
View
6 actionpack/lib/action_view/renderer/partial_renderer.rb
@@ -301,6 +301,12 @@ def setup(context, options, block)
paths.map! { |path| retrieve_variable(path).unshift(path) }
end
+ if String === partial && @variable !~ /^[a-z_][a-zA-Z_0-9]*$/
+ raise ArgumentError.new("The partial name (#{partial}) is not a valid Ruby identifier; " +
+ "make sure your partial name starts with a letter or underscore, " +
+ "and is followed by any combinations of letters, numbers, or underscores.")
+ end
+
self
end
View
1 actionpack/test/fixtures/test/_200.html.erb
@@ -0,0 +1 @@
+<h1>Invalid partial</h1>
View
9 actionpack/test/template/render_test.rb
@@ -98,6 +98,15 @@ def test_render_partial_with_locals_from_default
assert_equal "only partial", @view.render("test/partial_only", :counter_counter => 5)
end
+ def test_render_partial_with_invalid_name
+ @view.render(:partial => "test/200")
+ flunk "Render did not raise ArgumentError"
+ rescue ArgumentError => e
+ assert_equal "The partial name (test/200) is not a valid Ruby identifier; " +
+ "make sure your partial name starts with a letter or underscore, " +
+ "and is followed by any combinations of letters, numbers, or underscores.", e.message
+ end
+
def test_render_partial_with_errors
@view.render(:partial => "test/raise")
flunk "Render did not raise Template::Error"

0 comments on commit 7669c33

Please sign in to comment.
Something went wrong with that request. Please try again.