Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP
Browse files

Disable active record marshalling tests on Ruby 1.8.7 on Travis CI, a…

…s they have been failing intermittently for a long while due to what appears to be a Ruby bug. If anyone has the skills/expertise/time to debug this, please speak to the Travis guys.
  • Loading branch information...
commit 77ff1ce541f96a7703a4083454166f0ee82fd812 1 parent 3c846c2
@jonleighton jonleighton authored
View
10 activerecord/test/cases/associations/extension_test.rb
@@ -36,6 +36,11 @@ def test_extension_with_scopes
end
def test_marshalling_extensions
+ if ENV['TRAVIS'] && RUBY_VERSION == "1.8.7"
+ return skip("Marshalling tests disabled for Ruby 1.8.7 on Travis CI due to what appears " \
+ "to be a Ruby bug.")
+ end
+
david = developers(:david)
assert_equal projects(:action_controller), david.projects.find_most_recent
@@ -46,6 +51,11 @@ def test_marshalling_extensions
end
def test_marshalling_named_extensions
+ if ENV['TRAVIS'] && RUBY_VERSION == "1.8.7"
+ return skip("Marshalling tests disabled for Ruby 1.8.7 on Travis CI due to what appears " \
+ "to be a Ruby bug.")
+ end
+
david = developers(:david)
assert_equal projects(:action_controller), david.projects_extended_by_name.find_most_recent
View
15 activerecord/test/cases/base_test.rb
@@ -1835,6 +1835,11 @@ def test_current_scope_is_reset
end
def test_marshal_round_trip
+ if ENV['TRAVIS'] && RUBY_VERSION == "1.8.7"
+ return skip("Marshalling tests disabled for Ruby 1.8.7 on Travis CI due to what appears " \
+ "to be a Ruby bug.")
+ end
+
expected = posts(:welcome)
marshalled = Marshal.dump(expected)
actual = Marshal.load(marshalled)
@@ -1843,6 +1848,11 @@ def test_marshal_round_trip
end
def test_marshal_new_record_round_trip
+ if ENV['TRAVIS'] && RUBY_VERSION == "1.8.7"
+ return skip("Marshalling tests disabled for Ruby 1.8.7 on Travis CI due to what appears " \
+ "to be a Ruby bug.")
+ end
+
marshalled = Marshal.dump(Post.new)
post = Marshal.load(marshalled)
@@ -1850,6 +1860,11 @@ def test_marshal_new_record_round_trip
end
def test_marshalling_with_associations
+ if ENV['TRAVIS'] && RUBY_VERSION == "1.8.7"
+ return skip("Marshalling tests disabled for Ruby 1.8.7 on Travis CI due to what appears " \
+ "to be a Ruby bug.")
+ end
+
post = Post.new
post.comments.build

2 comments on commit 77ff1ce

@jodosha

Which Ruby bug are you talking about?

@jonleighton
Collaborator

Here is an example: http://travis-ci.org/#!/rails/rails/builds/133479/L86

The object that comes back from Marshal appears to be corrupted in some way. It happens intermittently and the only environment where it has been reproduced is on the actual Travis CI VMs using 1.8.7.

They tried rebuilding the VMs a while ago but that did not solve it.

Please sign in to comment.
Something went wrong with that request. Please try again.