Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP
Browse files

Fixed incompatibility with Base#find with an array of ids that would …

…fail when using eager loading #1186 [Alisdair McDiarmid]

git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1259 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
  • Loading branch information...
commit 787951348bd498ef16e0c2f24aa677499bc6b1ef 1 parent 9f1b577
@dhh dhh authored
View
2  activerecord/CHANGELOG
@@ -1,5 +1,7 @@
*SVN*
+* Fixed incompatibility with Base#find with an array of ids that would fail when using eager loading #1186 [Alisdair McDiarmid]
+
* Fixed that validate_length_of lost :on option when :within was specified #1195 [jhosteny@mac.com]
* Added encoding and min_messages options for PostgreSQL #1205 [shugo]. Configuration example:
View
2  activerecord/lib/active_record/base.rb
@@ -349,7 +349,7 @@ def find(*args)
else
# Find multiple ids
ids_list = ids.map { |id| sanitize(id) }.join(',')
- result = find(:all, options.merge({ :conditions => "#{table_name}.#{primary_key} IN (#{ids_list})#{conditions}", :order => primary_key }))
+ result = find(:all, options.merge({ :conditions => "#{table_name}.#{primary_key} IN (#{ids_list})#{conditions}"}))
if result.size == ids.size
return result
else
Please sign in to comment.
Something went wrong with that request. Please try again.