Permalink
Browse files

use enum labels as form values. Achieved by `_before_type_cast`.

Closes #13650, #13672

This is an alternate implementation to solve #13650. Currently form fields
contain the enum value (eg. "1"). This breaks because the setter `enum=`
expects the label (eg. "active").

ActiveRecord::Enum allows you to use labels in your application but store numbers.
We should make sure that all parts after AR are dealing with labels and not the
underlying mapping to a number.

This patch defines `_before_type_cast` on every enum column to return the label.
This method is later used to fetch the value to display in form fields.

I deliberately copied the implementation of the enum getter instead of delegating to it.
This allows you to overwrite the getter and for example return a `Value Object` but have it
still work for form fields.
  • Loading branch information...
1 parent caa981d commit 792c66f868b27cfd4b71c541202caae4bee1d172 @senny senny committed Jan 11, 2014
Showing with 7 additions and 0 deletions.
  1. +3 −0 activerecord/lib/active_record/enum.rb
  2. +4 −0 activerecord/test/cases/enum_test.rb
View
3 activerecord/lib/active_record/enum.rb
@@ -87,6 +87,9 @@ def enum(definitions)
# def status() STATUS.key self[:status] end
define_method(name) { enum_values.key self[name] }
+ # def status_before_type_cast() STATUS.key self[:status] end
+ define_method("#{name}_before_type_cast") { enum_values.key self[name] }
+
pairs = values.respond_to?(:each_pair) ? values.each_pair : values.each_with_index
pairs.each do |value, i|
enum_values[value] = i
View
4 activerecord/test/cases/enum_test.rb
@@ -88,4 +88,8 @@ class EnumTest < ActiveRecord::TestCase
assert Book.written.create.written?
assert Book.read.create.read?
end
+
+ test "_before_type_cast returns the enum label (required for form fields)" do
+ assert_equal "proposed", @book.status_before_type_cast
+ end
end

0 comments on commit 792c66f

Please sign in to comment.