Permalink
Browse files

Deprecate passing a column to `quote`

It's only used to grab the type for type casting purposes, and we would
like to remove the type from the columns entirely.
  • Loading branch information...
sgrif committed Jan 10, 2015
1 parent ac6e654 commit 7bb620869725ad6de603f6a5393ee17df13aa96c
Showing with 6 additions and 0 deletions.
  1. +6 −0 activerecord/lib/active_record/connection_adapters/abstract/quoting.rb
@@ -10,6 +10,12 @@ def quote(value, column = nil)
return value.quoted_id if value.respond_to?(:quoted_id)
if column
ActiveSupport::Deprecation.warn(<<-MSG.squish)
Passing a column to `quote` has been deprecated. It is only used
for type casting, which should be handled elsewhere. See
https://github.com/rails/arel/commit/6160bfbda1d1781c3b08a33ec4955f170e95be11
for more information.
MSG
value = column.cast_type.type_cast_for_database(value)
end

0 comments on commit 7bb6208

Please sign in to comment.