Skip to content

Commit

Permalink
Remove deprecated method `ActiveRecord::Migrator.schema_migrations_ta…
Browse files Browse the repository at this point in the history
…ble_name`
  • Loading branch information
rafaelfranca committed Oct 23, 2017
1 parent c56ff22 commit 7df6e3f
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 9 deletions.
4 changes: 4 additions & 0 deletions activerecord/CHANGELOG.md
@@ -1,3 +1,7 @@
* Remove deprecated method `ActiveRecord::Migrator.schema_migrations_table_name`.

*Rafael Mendonça França*

* Remove deprecated method `supports_primary_key?`. * Remove deprecated method `supports_primary_key?`.


*Rafael Mendonça França* *Rafael Mendonça França*
Expand Down
5 changes: 0 additions & 5 deletions activerecord/lib/active_record/migration.rb
Expand Up @@ -1026,11 +1026,6 @@ def open(migrations_paths)
new(:up, migrations(migrations_paths), nil) new(:up, migrations(migrations_paths), nil)
end end


def schema_migrations_table_name
SchemaMigration.table_name
end
deprecate :schema_migrations_table_name

def get_all_versions(connection = Base.connection) def get_all_versions(connection = Base.connection)
if SchemaMigration.table_exists? if SchemaMigration.table_exists?
SchemaMigration.all_versions.map(&:to_i) SchemaMigration.all_versions.map(&:to_i)
Expand Down
4 changes: 0 additions & 4 deletions activerecord/test/cases/migration_test.rb
Expand Up @@ -1106,8 +1106,4 @@ def test_check_pending_with_stdlib_logger
def test_unknown_migration_version_should_raise_an_argument_error def test_unknown_migration_version_should_raise_an_argument_error
assert_raise(ArgumentError) { ActiveRecord::Migration[1.0] } assert_raise(ArgumentError) { ActiveRecord::Migration[1.0] }
end end

def test_deprecate_schema_migrations_table_name
assert_deprecated { ActiveRecord::Migrator.schema_migrations_table_name }
end
end end

0 comments on commit 7df6e3f

Please sign in to comment.