Skip to content
This repository
Browse code

Revert "DDL transactions and savepoints for sqlite"

This reverts commit 38136f8.

Caused several test failures on the ci box:

http://ci.rubyonrails.org/builds/rails/38136f
[#2080 state:open]
  • Loading branch information...
commit 818556ec4f237b19f28fdecdfe6037718cceba37 1 parent c41ed92
Michael Koziarski authored March 02, 2009
21  activerecord/lib/active_record/connection_adapters/sqlite_adapter.rb
@@ -72,29 +72,10 @@ def binary_to_string(value)
72 72
     #
73 73
     # * <tt>:database</tt> - Path to the database file.
74 74
     class SQLiteAdapter < AbstractAdapter
75  
-
76  
-      class Version
77  
-        include Comparable
78  
-        def initialize(vs)
79  
-          @v = vs.split('.').map(&:to_i)
80  
-        end
81  
-        def <=>(rhs)
82  
-          @v <=> rhs.split('.').map(&:to_i)
83  
-        end
84  
-      end
85  
-
86 75
       def adapter_name #:nodoc:
87 76
         'SQLite'
88 77
       end
89 78
 
90  
-      def supports_ddl_transactions?
91  
-        sqlite_version >= '2.0.0'
92  
-      end
93  
-
94  
-      def supports_savepoints?
95  
-        sqlite_version >= '3.6.8'
96  
-      end
97  
-
98 79
       def supports_migrations? #:nodoc:
99 80
         true
100 81
       end
@@ -399,7 +380,7 @@ def catch_schema_changes
399 380
         end
400 381
 
401 382
         def sqlite_version
402  
-          @sqlite_version ||= SQLiteAdapter::Version.new(select_value('select sqlite_version(*)'))
  383
+          @sqlite_version ||= select_value('select sqlite_version(*)')
403 384
         end
404 385
 
405 386
         def default_primary_key_type

0 notes on commit 818556e

Please sign in to comment.
Something went wrong with that request. Please try again.