Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP
Browse files

Fix PR #6091

1. ActiveRecord::Base is not ActiveRecord::Relation
2. The order of records from an SQL query is uncertain without an ORDER clause
3. Run your own tests when submitting a pull request
  • Loading branch information...
commit 838101ae04be06138f1bd7418473092b92754293 1 parent b7ec875
@pixeltrix pixeltrix authored
View
2  activerecord/lib/active_record/querying.rb
@@ -11,7 +11,7 @@ module Querying
delegate :select, :group, :order, :except, :reorder, :limit, :offset, :joins,
:where, :preload, :eager_load, :includes, :from, :lock, :readonly,
:having, :create_with, :uniq, :references, :none, :to => :scoped
- delegate :count, :average, :minimum, :maximum, :sum, :calculate, :pluck, :to => :scoped
+ delegate :count, :average, :minimum, :maximum, :sum, :calculate, :pluck, :ids, :to => :scoped
# Executes a custom SQL query against your database and returns all the results. The results will
# be returned as an array with columns requested encapsulated as attributes of the model you call
View
2  activerecord/test/cases/calculations_test.rb
@@ -467,6 +467,6 @@ def test_pluck_not_auto_table_name_prefix_if_column_joined
end
def test_plucks_with_ids
- assert_equal Company.all.map(&:id), Company.ids
+ assert_equal Company.all.map(&:id).sort, Company.ids.sort
end
end
Please sign in to comment.
Something went wrong with that request. Please try again.