Permalink
Browse files

Add CHANGELOG for #14886

Also cleanup test a bit

[related #14886]
[related #14743]
  • Loading branch information...
1 parent 9ff18e4 commit 86433b8d5f1a7d28e0bb6ceeaf824e67acf4b759 @arthurnn arthurnn committed Jul 18, 2014
Showing with 6 additions and 1 deletion.
  1. +5 −0 actionpack/CHANGELOG.md
  2. +1 −1 actionpack/test/dispatch/request_test.rb
View
5 actionpack/CHANGELOG.md
@@ -1,3 +1,8 @@
+* Allows ActionDispatch::Request::LOCALHOST to match any IPv4 127.0.0.0/8
+ loopback address.
+
+ *Earl St Sauver*, *Sven Riedel*
+
* Preserve original path in `ShowExceptions` middleware by stashing it as
`env["action_dispatch.original_path"]`
View
2 actionpack/test/dispatch/request_test.rb
@@ -531,7 +531,7 @@ class RequestCGI < BaseRequestTest
class LocalhostTest < BaseRequestTest
test "IPs that match localhost" do
request = stub_request("REMOTE_IP" => "127.1.1.1", "REMOTE_ADDR" => "127.1.1.1")
- assert_equal !!request.local?, true
+ assert request.local?
end
end

0 comments on commit 86433b8

Please sign in to comment.