Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP
Browse files

Merge pull request #12750 from arunagw/webconsole-invite-only

Not adding webconsole by default in new apps
  • Loading branch information...
commit 876fd5a5d4f424e6699a66058a13c9cda8d92f64 2 parents 2b66f55 + fae08dd
Guillermo Iguaran guilleiguaran authored
4 railties/CHANGELOG.md
View
@@ -19,10 +19,6 @@
*Ben Pickles*
-* Include `web-console` into newly generated applications' Gemfile.
-
- *Genadi Samokovarov*
-
* `rails server` will only extend the logger to output to STDOUT
in development environment.
6 railties/lib/rails/generators/app_base.rb
View
@@ -109,7 +109,6 @@ def gemfile_entries
assets_gemfile_entry,
javascript_gemfile_entry,
jbuilder_gemfile_entry,
- webconsole_gemfile_entry,
sdoc_gemfile_entry,
@extra_entries].flatten.find_all(&@gem_filter)
end
@@ -261,11 +260,6 @@ def jbuilder_gemfile_entry
GemfileEntry.version('jbuilder', '~> 1.2', comment)
end
- def webconsole_gemfile_entry
- comment = 'Run `rails console` in the browser. Read more: https://github.com/rails/web-console'
- GemfileEntry.new('web-console', nil, comment, group: :development)
- end
-
def sdoc_gemfile_entry
comment = 'bundle exec rake doc:rails generates the API under doc/api.'
GemfileEntry.new('sdoc', nil, comment, { group: :doc, require: false })
5 railties/test/generators/app_generator_test.rb
View
@@ -313,11 +313,6 @@ def test_javascript_is_skipped_if_required
end
end
- def test_inclusion_of_web_console
- run_generator
- assert_file "Gemfile", /gem 'web-console', \s+group: :development/
- end
-
def test_inclusion_of_jbuilder
run_generator
assert_file "Gemfile", /gem 'jbuilder'/
Please sign in to comment.
Something went wrong with that request. Please try again.