Permalink
Browse files

Changed the observe field node into a div with display:none

  • Loading branch information...
1 parent fab8b25 commit 88e793e5e77efbd43a5a2bb4eaba283255f6a262 @foobarfighter foobarfighter committed with stefanpenner Sep 23, 2009
Showing with 20 additions and 11 deletions.
  1. +8 −3 actionpack/lib/action_view/helpers/ajax_helper.rb
  2. +12 −8 actionpack/test/javascript/ajax_test.rb
@@ -38,12 +38,17 @@ def observe_field(name, options = {}, html_options = {})
url = options.delete(:url)
url = url_for(url) if url.is_a?(Hash)
- if frequency = options.delete(:frequency)
+ frequency = options.delete(:frequency)
+ if frequency && frequency > 0
html_options[:"data-frequency"] = frequency
end
- html_options.merge!(:"data-observe" => true, :"data-url" => url)
- tag(:input, html_options)
+ html_options.merge!(:style => "display:none",
+ :"data-observe-field" => name,
+ :"data-observe" => true,
+ :"data-url" => url)
+
+ tag(:div, html_options)
end
module Rails2Compatibility
@@ -123,22 +123,26 @@ def field(options = {})
test "basic" do
assert_html field,
- %w(data-observe="true")
- end
-
- test "with a :frequency option" do
- assert_html field(:frequency => 5.minutes),
- %w(data-observe="true" data-frequency="300")
+ %w(div style="display:none" data-observe="true" data-observe-field="title")
end
test "using a url string" do
assert_html field(:url => "/some/other/url"),
- %w(data-observe="true" data-url="/some/other/url")
+ %w(data-url="/some/other/url")
end
test "using a url hash" do
assert_html field(:url => {:controller => :blog, :action => :update}),
- %w(data-observe="true" data-url="/url/hash")
+ %w(data-url="/url/hash")
+ end
+
+ test "with a :frequency option" do
+ assert_html field(:frequency => 5.minutes),
+ %w(data-frequency="300")
+ end
+
+ test "with a :frequency option of 0" do
+ assert_no_match /data-frequency/, field(:frequency => 0)
end
# def test_observe_field

0 comments on commit 88e793e

Please sign in to comment.