Skip to content
This repository
Browse code

Document caveat from 5b3bb61 which fixed handling SCRIPT_NAME from wi…

…thin mounted engine
  • Loading branch information...
commit 8ecc2edcd0b9ff3e03c427fdbdeb329d4e65ac60 1 parent 1525268
Trevor Turk trevorturk authored

Showing 1 changed file with 3 additions and 0 deletions. Show diff stats Hide diff stats

  1. +3 0  guides/source/upgrading_ruby_on_rails.md
3  guides/source/upgrading_ruby_on_rails.md
Source Rendered
@@ -116,6 +116,9 @@ Also check your environment settings for `config.action_dispatch.best_standards_
116 116
117 117 * In Rails 4.0, a rescuable exception `ActionController::UnknownFormat` is raised when Rails doesn't know what to do with the request format, rather than responding with a head :not_acceptable (406).
118 118
  119 +* In Rails 4.0, `SCRIPT_NAME` is properly handled for mounted apps and engines. One caveat of the fix is that you should *not* set
  120 +`default_url_options[:script_name]` explicitly if your server already passes correct `SCRIPT_NAME` to rack env.
  121 +
119 122 ### Active Support
120 123
121 124 Rails 4.0 removes the `j` alias for `ERB::Util#json_escape` since `j` is already used for `ActionView::Helpers::JavaScriptHelper#escape_javascript`.

0 comments on commit 8ecc2ed

Please sign in to comment.
Something went wrong with that request. Please try again.