Permalink
Browse files

Deprecating passing strings as class name in fixtures.

  • Loading branch information...
1 parent b77f25c commit 92b0ce942f995de0988b998d1780fb8844fda1c9 @wangjohn wangjohn committed Aug 23, 2013
Showing with 1 addition and 7 deletions.
  1. +1 −7 activerecord/lib/active_record/fixtures.rb
@@ -507,6 +507,7 @@ def initialize(connection, name, class_name, path)
if class_name.is_a?(Class) # TODO: Should be an AR::Base type class, or any?
@model_class = class_name
else
+ ActiveSupport::Deprecation.warn("The ability to pass in strings as a class name will be removed in Rails 4.1, consider using the class itself instead.")
@model_class = class_name.constantize rescue nil
end
@@ -743,13 +744,6 @@ module ClassMethods
# 'namespaced/fixture' => Another::Model
#
# The keys must be the fixture names, that coincide with the short paths to the fixture files.
- #--
- # It is also possible to pass the class name instead of the class:
- # set_fixture_class 'some_fixture' => 'SomeModel'
- # I think this option is redundant, i propose to deprecate it.
- # Isn't it easier to always pass the class itself?
- # (2011-12-20 alexeymuranov)
- #++
def set_fixture_class(class_names = {})
self.fixture_class_names = self.fixture_class_names.merge(class_names.stringify_keys)
end

3 comments on commit 92b0ce9

@pftg
pftg commented on 92b0ce9 Aug 24, 2013

After this commit, there are a lot of warning messages, that Travis do not show all build log.

@wangjohn

Yep, sorry about that. I'm in the process of getting rid of those deprecation messages in this PR: https://github.com/rails/rails/pull/12009/files#r5965564

@pftg
pftg commented on 92b0ce9 Aug 24, 2013

Cool!

Please sign in to comment.