Please sign in to comment.
Fix for #371
if a query contains a limit or an offset, ActiveRecord::FinderMethods#find_last had inconsistent behavior. If the records were loaded, it returned the last record in the cached list. If they were not, it reversed the order of the query and changed the limit to one. If the earlier limit was less than the total matching the query in the db, it would return a different record than if the records had been cached. This commit changes find_last so that it loads the records when getting the last record on a query containing a limit or an offset, which makes the behavior consistent.
- Loading branch information...
Showing with 27 additions and 1 deletion.
|@@ -375,7 +375,12 @@ def find_last|
|- @last ||= reverse_order.limit(1).to_a|
|+ @last ||=|
|+ if offset_value || limit_value|